Skip to content

Add coplanar decimation#5461

Merged
lrineau merged 98 commits intoCGAL:masterfrom
sloriot:PMP-decimation
Apr 17, 2023
Merged

Add coplanar decimation#5461
lrineau merged 98 commits intoCGAL:masterfrom
sloriot:PMP-decimation

Conversation

@sloriot
Copy link
Member

@sloriot sloriot commented Feb 15, 2021 •
edited
Loading

Summary of Changes

Add two functions in PMP that generate from a triangle mesh a new version with patches of (almost) coplanar faces being retriangulated while removing interior vertices and collinear boundary vertices:

TODO:

  • split the example in 2, one part should go into test (together with the data provided)
  • decide license group
  • small feature
  • fix dependencies
  • update PMP user manual
  • demo plugins
  • Update changes.md
  • add an option to to triangulate faces
  • debug bracket

Release Management

  • Affected package(s): PMP,
  • Feature/Small Feature (if any): here, pre-approved 20 March 2023
  • Link to compiled documentation (obligatory for small feature) here
  • License and copyright ownership: GF

@sloriot sloriot added Not yet approved The feature or pull-request has not yet been approved. Small feature TODO Pkg::PMP labels Feb 15, 2021
@sloriot sloriot mentioned this pull request Feb 15, 2021
Closed
@sloriot

This comment was marked as outdated.

Sign in to view
@sloriot sloriot mentioned this pull request Feb 18, 2021
Closed
8 tasks
@sloriot

This comment was marked as outdated.

Sign in to view
@danston danston added the depends on another PR This pull-request should only be merged after other ones. label Sep 16, 2021
@sloriot sloriot added this to the 5.5-beta1 milestone Sep 23, 2021
@danston danston mentioned this pull request Sep 29, 2021
Closed
@sloriot sloriot mentioned this pull request Nov 26, 2021
Closed
6 tasks
@sloriot
Copy link
Member Author

sloriot commented Apr 11, 2023

Runtime error here

@sloriot sloriot added Under Testing Accepted small feature Tested and removed Tests failing pre-approved For pre-approved small features. After 15 days the feature will be accepted. TODO Under Testing labels Apr 12, 2023
@sloriot
Copy link
Member Author

sloriot commented Apr 16, 2023

Successfully tested in CGAL-5.6-Ic-223

@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Apr 17, 2023
@lrineau lrineau merged commit 594682d into CGAL:master Apr 17, 2023
@lrineau lrineau removed rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' Ready to be tested labels Apr 17, 2023
@lrineau lrineau deleted the PMP-decimation branch April 17, 2023 08:26
@MaelRL MaelRL mentioned this pull request Sep 13, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afabri afabri afabri left review comments

@MaelRL MaelRL MaelRL left review comments

@lrineau lrineau lrineau left review comments

+1 more reviewer

@albert-github albert-github albert-github left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lrineau lrineau

Labels

Accepted small feature Merged_in_5.6-beta1 Merged_in_5.6 Pkg::PMP Pkg::Surface_mesh_segmentation rm only: release blocker For the release team only: the next release requires this issue/PR to be solved/merge Small feature Tested

Projects

None yet

Milestone

5.6-beta

Development

Successfully merging this pull request may close these issues.

8 participants

@sloriot @ochafik @afabri @MaelRL @albert-github @lrineau @danston @soesau