Potential error(e.g., deadlock, ill peformance) due to the &stats.lock #964
Description
Hi, developers, thank you for your checking. The lock &stats.lock may not be correctly released if the realloc fails. Finally, the method returns with the unreleased lock. The fix is to insert pthread_mutex_unlock(&stats.lock); before returning.
netopeer2/src/netconf_monitoring.c
Line 143 in a68ff29
netopeer2/src/netconf_monitoring.c
Line 153 in a68ff29
void
ncm_session_add(struct nc_session *session)
{
...;
pthread_mutex_lock(&stats.lock);
++stats.in_sessions;
++stats.session_count;
new = realloc(stats.sessions, stats.session_count * sizeof *stats.sessions);
if (!new) {
EMEM;
return; //return without releasing the lock
}
stats.sessions = new;
new = realloc(stats.session_stats, stats.session_count * sizeof *stats.session_stats);
if (!new) {
EMEM;
return; //return without releasing the lock
}
...;
pthread_mutex_unlock(&stats.lock);
}
Best,