Fix and optimize clipping behavior for gfx_HorizLine and gfx_VertLine#678
Merged
mateoconlechuga merged 1 commit intomasterfrom Dec 22, 2025
Merged
Fix and optimize clipping behavior for gfx_HorizLine and gfx_VertLine#678mateoconlechuga merged 1 commit intomasterfrom
mateoconlechuga merged 1 commit intomasterfrom
Conversation
Contributor
|
Yey! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #673, verified fix against FishCE and using a new test program.
Also, as a behavioral fix compared to before the clipping logic was broken, signed overflow of start + length is handled as if saturated (so negative lengths are never drawn, and positive lengths causing an overflow past INT_MAX will be drawn all the way to the right of the clip region).