Improved 'Check for updates' button#51
Merged
techno-disaster merged 4 commits intoCCExtractor:masterfrom Apr 3, 2023
Merged
Conversation
Placed the 'check for updates' button in the header instead of the footer to better incorporate changes I made in techno-disaster/navigation_rail#1
lib/screens/home.dart
Outdated
| ); | ||
| } | ||
|
|
||
| Widget _checkForUpdates(ProcessState state) { |
Member
There was a problem hiding this comment.
nitpick, can you make this a Stateless widget rather than a function returning a widget?
Contributor
Author
There was a problem hiding this comment.
Sure thing, added it!
Converted the `_checkForUpdates` local method to a private Stateless Widget `_CheckForUpdates`
lib/screens/home.dart
Outdated
| builder: (context, state) { | ||
| return Column( | ||
| children: [_checkForUpdates(state)], | ||
| children: [_CheckForUpdatesButton(state: state)], |
Member
There was a problem hiding this comment.
Just move the whole BlocBuilder to the widget? since only that needs the state. Also probably don't need a column?
lib/screens/home.dart
Outdated
| builder: (context, state) { | ||
| return Column( | ||
| children: [_checkForUpdates(state)], | ||
| children: [_CheckForUpdatesButton(state: state)], |
Member
There was a problem hiding this comment.
Just move the whole BlocBuilder to the widget? since only that needs the state. Also probably don't need a column?
Contributor
Author
There was a problem hiding this comment.
oops overlooked that, updated it now
removed redundant code
import_sorter fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Update navigation_rail.dart techno-disaster/navigation_rail#1
*fixes overflow in navigation rail by making it scrollable