Added Drag And Drop Support For The Desktop Application#41
Added Drag And Drop Support For The Desktop Application#41techno-disaster merged 14 commits intoCCExtractor:masterfrom manoj1749:master
Conversation
|
Can you make the whole windows the drop target and keep the button labelled "Add files"? |
Yeah I can do that |
Working Videoupdated_dnd.mp4 |
|
LGTM, one small change, upon hover can you change the drop area to "drop files here" or something similar? |
|
also formatting and stuff, ci fails atm |
|
I think it was due to the flutter format command as if you check the log in line 37 it states " [!] The "format" command is deprecated and will be removed in a future version of Flutter. Please use the "dart format" sub-command instead, which takes all of the same command-line arguments as "flutter format". 37 " |
ok will try to do that |
|
Heyy, @techno-disaster , I've tried to do what you said and basically the text in the drop area is a seperate widget and it's state can't be updated whenever we move files into the window to drop. |
Why not? maybe you can try listening to |
Ohk, Thanks for suggesting it, I will work on it and update you soon |
dnd_updated.mp4 |
|
|
Strange, they should work in the ci too. Looks like something is wrong with bloc_test.dart? Can you confirm if it works on flutter 3.7.3? |
You mean the flutter version I am using? |
|
yep, if yes maybe look into why ci tests are failing too :D |
The version I had is 3.3.9, I had tried googling about the error but what I can find is problem with the bloc_test.dart |
|
Try upgrading to 3.7.3, the bloc test probably shows some analyzer warnings and breaks locally then too. |
Yeah I had upgraded to 3.7.3, it's showing an error same as the one which we are getting in the CI tests |
|
As from what I had seen, the error is due to the package called file, as you can see it from the error |
upgraded file to newer version and added it in yaml file
|
Solved the issues, ci tests are not failing, @techno-disaster now the tests are not failing in anything |
|
LGTM, nice work! |
|
Thanks😁 |

ccextractor/issue-1413
Working Video
dnd_working.mp4