Hi, this LGTM and should mostly work because you also added the sequential transfrom, could you try it out with the other options from bloc_concurrency? Would like to know where this could break and if it has any possible perf improvments

ci fails due to formatting issues, can you fix that?

ci fails due to formatting issues, can you fix that?

Hi, i don't have knowledge on ci/cd pipeline but I can surely try 😄.. although it would take some time

I think flutter analyze should be run before flutter format in workflows as running flutter format first isn't helping in identifying issues.

Although I'm not sure that this commit won't fail :)

I'll try to fix CI failure

Could you please run the checks again?

Looks like formatting still fails could you run

flutter format . 
flutter pub get
flutter pub run import_sorter:main --no-comments 

Looks like formatting still fails could you run

flutter format . 
flutter pub get
flutter pub run import_sorter:main --no-comments 

I sorted the imports

@techno-disaster, please run the tests again :)

How can I check all the workflows locally without having you run the tests again and again ...might be a dumb question :)

How can I check all the workflows locally without having you run the tests again and again ...might be a dumb question :)

flutter format . 
flutter pub get
flutter pub run import_sorter:main --no-comments 
flutter test

should be enough I guess

How can I check all the workflows locally without having you run the tests again and again ...might be a dumb question :)

flutter format . 
flutter pub get
flutter pub run import_sorter:main --no-comments 
flutter test

should be enough I guess

thanks !

I think it should work now :")

Hi, this LGTM and should mostly work because you also added the sequential transfrom, could you try it out with the other options from bloc_concurrency? Would like to know where this could break and if it has any possible perf improvments

@rajoriaakash were you able to look into this?

Hi, this LGTM and should mostly work because you also added the sequential transfrom, could you try it out with the other options from bloc_concurrency? Would like to know where this could break and if it has any possible perf improvments

@rajoriaakash were you able to look into this?

I haven't looked into it as of now, will look.
This build_linux test is failing due to the package manager ig and is unrelated to my changes.

I checked all the options from bloc_concurrency and idts it would fail on any of them. Although I think sequential is good to go.

Yep SGTM, the default was sequential anyway. Thanks for your work! A couple of merge conflicts, do you think you can fix them anytime soon?

Also bloc v9 is a thing but should be easy to migrate afaik.

@hrideshmg maybe you can takeover this PR for the block changes?

Thank you for the effort on this migration! Unfortunately, this PR has been open for nearly 4 years and has accumulated merge conflicts. Additionally, Bloc v9 is now available, so a v8 migration is no longer the right target.

Closing this as it would need to be redone from scratch targeting the current Bloc version. Thanks for your contribution to the project!