carli/1937_cursor_info_for_spatial_profile_smoothing#1938
carli/1937_cursor_info_for_spatial_profile_smoothing#1938YuHsuan-Hwang merged 11 commits intodevfrom
Conversation
crocka
changed the title
|
@crocka for the spatial profiler widget, we will also need to show the smoothed x value along with the smoothed y value too. Once it is added, a PR it is 👍
|
There was a problem hiding this comment.
@crocka thanks for adding the smoothed x value to the cursor info. We need to considered the smoothed x value as well (eg with binning, smoothed x is not necessary identical to the raw x).
Screen.Recording.2022-09-19.at.13.27.03.mov
As for the smoothed wcs, it is a bit tricky I think due to the non-linear nature. I suggest we don't show smoothed wcs for now.
|
@crocka good for a PR 👍 |
YuHsuan-Hwang
left a comment
YuHsuan-Hwang
left a comment
There was a problem hiding this comment.
overall looks good 👍
kswang1029
left a comment
kswang1029
left a comment
There was a problem hiding this comment.
manual test looks fine. no regression is observed from e2e tests. 👍
|
@crocka Please resolve conflicts and update changelog. |
YuHsuan-Hwang
deleted the
carli/1937_cursor_info_for_spatial_profile_smoothing
branch
3 participants
Description
A method called genSmoothedProfilerInfo is created. It extracts the y value of the smoothed profile and display the info below the spatial profiler.
Checklist
no changelog update neededadded corresponding fixprotobuf updated to the latest dev commit/ no protobuf update needed