Merged
Conversation
Collaborator
Author
|
moving back to draft until @confluence has finished her gRPC removal branch. |
Collaborator
Author
|
@confluence do you think this is ready for a PR and merge yet? |
Collaborator
|
I'm still testing the controller integration, but it should be ready very soon. |
…arta-controller into angus/scripting_token_support
This was referenced Feb 16, 2022
Collaborator
|
This PR should be merged at the same time as the companion PRs in the wrapper, backend, frontend, protocol buffers and website. |
confluence
approved these changes
Feb 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic scripting support:
User can generate a scripting API token and copy it to clipboard using the "Copy scripting token"/api/auth/refreshendpoint (with{"scripting": true}in the JSON body)/api/scripting/*are proxied to the backend after verifying that they have a valid auth token header (i.e.Authoirzation: Bearer <token>) and that the token has the validated claimscripting: true.