Considering NaN in downsampled spatial profile data#987
Merged
confluence merged 5 commits intodevfrom Jan 11, 2022
Merged
Conversation
…mark/consider_nan_in_downsample_spatial_profile
…mark/consider_nan_in_downsample_spatial_profile
confluence
approved these changes
Dec 17, 2021
veggiesaurus
approved these changes
Jan 11, 2022
confluence
deleted the
mark/consider_nan_in_downsample_spatial_profile
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe it is not a critical bug. Using
std::minmax_elementorstd::min_element/std::max_elementcan not get the right min/max values from a segment if it contains NaN elements. To show it, introducing random NaN in generated images and remove this code line, then some of the spatial profile tests would fail. This PR is part of #797 for the cursor/point region spatial profile test.