Merged
Conversation
…pting flag from session manager instead of passing redundant parameter.
…ndpoints. Tweaked commandline options and help text; added deprecation warnings. Fixed some bugs.
… session is destroyed.
…stalled as a dependency of protobuf-compiler-grpc, which was removed.
…to clean up function parameter definitions.
This was referenced Feb 16, 2022
veggiesaurus
requested changes
Feb 16, 2022
Collaborator
veggiesaurus
left a comment
veggiesaurus
left a comment
There was a problem hiding this comment.
one very minor comment from me, otherwise looks great.
veggiesaurus
approved these changes
Feb 16, 2022
jolopezl
suggested changes
Feb 16, 2022
Contributor
jolopezl
left a comment
jolopezl
left a comment
There was a problem hiding this comment.
Looks great!. I added one minor comment regarding deprecated variables. But more importantly, can I suggest changing the name of SimpleHttpServer to HttpServer?
jolopezl
approved these changes
Feb 16, 2022
jolopezl
approved these changes
Feb 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the gRPC server and moves the scripting API to an endpoint in the HTTP server. The HTTP server has been renamed, and its different functions have been decoupled from one another so that they can be enabled and disabled independently. Commandline options have been adjusted.
This PR should be merged at the same time as the companion PRs in the wrapper, frontend, protocol buffers, controller and website.