Avoid the file id repetition in generated moments or PV images#1003
Merged
kswang1029 merged 1 commit intodevfrom Jan 18, 2022
Merged
Avoid the file id repetition in generated moments or PV images#1003kswang1029 merged 1 commit intodevfrom
kswang1029 merged 1 commit intodevfrom
Conversation
veggiesaurus
approved these changes
Jan 17, 2022
kswang1029
approved these changes
Jan 18, 2022
Contributor
kswang1029
left a comment
kswang1029
left a comment
There was a problem hiding this comment.
@YuHsuan-Hwang thanks for spotting this issue. @markccchiang thanks for fixing this proactively. Tested with multiple cubes loaded and generated PV each and moments -1 and 0 to verify the fix. All working properly. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug was found by @YuHsuan-Hwang. The file id of the generated moment image is repeated with the PV image if the number of moment type is 0 (PV generator file id def). So I increase the file id for moments images by 1 to solve this problem.