change some rsa oaep tests to acceptable#145
Merged
cpu merged 1 commit intoC2SP:masterfrom May 2, 2025
Merged
Conversation
cpu
approved these changes
May 1, 2025
Member
cpu
left a comment
cpu
left a comment
There was a problem hiding this comment.
LGTM.
Would you mind squashing everything into one commit? Alternatively we could squash-merge on our end. Either works for me :-)
Contributor
Author
|
I can squash it, one moment 😄 |
NIST SP800-56Br2 Section 7.1.2.1 specifies that when decrypting a ciphertext outside the range 1 < ct < (n-1) should be rejected. The test cases updated in this commit had a ct integer value of 1 or 0, which violate this requirement.
Contributor
Author
|
Done 😄 |
alex
approved these changes
May 2, 2025
FiloSottile
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIST SP800-56Br2 Section 7.1.2.1 specifies that when decrypting a ciphertext outside the range 1 < ct < (n-1) it should be rejected. The test cases updated in this commit had a ct integer value of 1 or 0, which violate this requirement.
This also adds a new flag
SmallIntegerCiphertextto make it easier for consumers to skip on this.