fix(windows): use ShellExecuteExW to avoid freeze when opening directories#98
Merged
Merged
Conversation
Byron
requested changes
May 16, 2024
Byron
left a comment
Byron
left a comment
Owner
There was a problem hiding this comment.
Thanks so much for looking into this!
Even though this PR is basically mergeable as is, I think there is an opportunity to reduce duplication.
Once that is figured out, I will be happy to merge and create a new release for downstream consumption.
Co-authored-by: Sebastian Thiel <[email protected]>
Contributor
Author
|
Thanks |
Byron
approved these changes
May 16, 2024
Owner
There was a problem hiding this comment.
Great work, thank you!
A new patch release is now available: https://github.com/Byron/open-rs/releases/tag/v5.1.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: tauri-apps/plugins-workspace#1137
ref: tauri-apps/tauri#9624
reference implementation in chromium: https://source.chromium.org/chromium/chromium/src/+/main:ui/base/win/shell.cc;l=83;drc=7e088bf159ef779ea494dd55bb48916be569b06a?q=OpenFileViaShell&ss=chromium%2Fchromium%2Fsrc