Skip to content

fix: handle dump sym errors#175

Merged
bobbyg603 merged 1 commit intomainfrom
dumpsyms-fix
Sep 30, 2025
Merged

fix: handle dump sym errors#175
bobbyg603 merged 1 commit intomainfrom
dumpsyms-fix

Conversation

@bobbyg603
Copy link
Copy Markdown
Member

@bobbyg603 bobbyg603 commented Sep 30, 2025

Description

Fixes #174

Checklist

  • Tested manually
  • Unit tests pass with no errors or warnings
  • Documentation updated (if applicable)
  • Reviewed by at least 1 other contributor

Note

Handle dump_syms failures by skipping failed files and erroring if none are produced.

  • CLI (bin/index.ts):
    • Robust symbol dumping: iterate files with a for...of, wrap nodeDumpSyms in try/catch, warn and skip on failure, and collect successful outputs.
    • Validation: throw an error if no valid symbol files were produced after dumping.

Written by Cursor Bugbot for commit 9310e05. This will update automatically on new commits. Configure here.

@bobbyg603
Copy link
Copy Markdown
Member Author

@cursor review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


@bobbyg603 bobbyg603 merged commit a753bf3 into main Sep 30, 2025
8 checks passed
@bobbyg603 bobbyg603 deleted the dumpsyms-fix branch September 30, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dump Syms should not Exit on Failure

2 participants