fix: dump_syms fails due to incorrect path handling#162
Merged
Conversation
4 tasks
daveplunkett
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The logic used to determine the module and sym file names used by Crashpad is bananas.
.pdbexists in the module portion of the path but not the sym file name eg,thing.pdb/GUID/thing.sym.so.*exists in both the module portion and the sym file name eg,thing.so.6/GUID/thing.so.6.sym.dSYMalways gets removed, and.dylib.dSYMgets trimmed tothing.dylib/GUID/thing.dylib.symbut.app.dSYMgets trimmed tothing/GUID/thing.sym.debugalways gets removed, and.so.2.debuggets trimmed tothing.so.2/GUID/thing.so.2.symFixes #160
Checklist