Skip to content

BI-1340 - Allow system admin, memeber roles to fully read Ontology #293

Merged
mlm483 merged 1 commit intodevelopfrom
bug/BI-1340
Oct 2, 2023
Merged

BI-1340 - Allow system admin, memeber roles to fully read Ontology #293
mlm483 merged 1 commit intodevelopfrom
bug/BI-1340

Conversation

@mlm483
Copy link
Copy Markdown
Contributor

@mlm483 mlm483 commented Sep 26, 2023

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1340

Previously, a user logged in as a system admin or a member of a breeding program could not see the sharing status on the Ontology list view (see Jira comments for more background).

  • Updated getSubscribedOntology (GET) endpoint authorization to allow read access to any authenticated user.

Dependencies

None

Testing

  1. Upload Ontology to program A.
  2. [Regression Test] Go to the program A Ontology list view as (1) system admin, (2) breeder, (3) member and ensure only the breeder role can edit Ontology Terms (expand a Term's detail view to try to edit).
  3. Share program A's Ontology Terms with program B.
  4. Accept the shared Ontology Terms in program B.
  5. Go to the program B Ontology list view as (1) system admin, (2) breeder, (3) member and ensure "This Ontology is shared from A" message is visible above the table.

Checklist:

made getSubscribedOntology (GET) accessible to any authenticated user
@github-actions github-actions bot added the bug Something isn't working label Sep 26, 2023
@mlm483 mlm483 marked this pull request as ready for review September 26, 2023 17:58
@mlm483 mlm483 requested review from a team, dmeidlin and timparsons and removed request for a team September 26, 2023 17:58
@mlm483 mlm483 merged commit 193c451 into develop Oct 2, 2023
@mlm483 mlm483 deleted the bug/BI-1340 branch October 2, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants