Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
glory.transactionto better surface processing status and errors.Description
glory.transaction.pos_payment_uuidand added fieldsstate,pos_payment_uuid,attempt_count,last_error, andprocessed_attoglory.transactionfor lifecycle and error tracking, and adjusted the form/tree/search views to display and filter on these fields.pos.session.generate_glory_transactionandtry_write_glory_transactionto accept and persistpos_payment_uuid, initializeattempt_count/processed_at, and setstateautomatically for payment/refund/aborted operations.pos.order.create_from_uito map incoming UI order payloads and link existingglory.transactionrecords to orders using theglory_payment_uuidembedded in statement lines before falling back to the previous matching logic.action_set_glory_on_orderto attempt to link payments to transactions bypos_payment_uuidwhen marking orders.glory_payment_uuidon paymentlines by extending thePaymentmodel to persist the UUID and by setting it when a Glory paymentline is created; ensure all RPC calls totry_write_glory_transactioninclude the payment UUID; adjusted paymentline status flow when sending requests.diff_stacker_bill_50_00) that was previously pointing to the wrong field name.Testing
glory_payment_uuidis attached, propagated to the server RPCs, and that transactions are linked topos.orderrecords; these manual checks succeeded.Codex Task