Skip to content

Code smell fixes#22

Merged
Borewit merged 1 commit into
mainfrom
code-fixes
Mar 5, 2023
Merged

Code smell fixes#22
Borewit merged 1 commit into
mainfrom
code-fixes

Conversation

@Borewit

@Borewit Borewit commented Mar 4, 2023

Copy link
Copy Markdown
Owner

Changes:

  • Simplifies expressions with binary operators
  • Remove fully qualified Object references, use import instead
  • Remove unnecessary throws
  • Remove, presumably unused / not required to import directly, dependencies:
    • asm:asm:3.3.1
    • commons-beanutils:commons-beanutils-core:1.8.3
    • commons-collections:commons-collections:3.2.2
    • commons-jexl:commons-jexl:1.0
    • org.dom4j:dom4j:2.1.4
    • xml-apis:xml-apis:1.4.01
    • com.sun.activation:javax.activation:1.2.0

@Borewit Borewit self-assigned this Mar 4, 2023
@Borewit Borewit added the debt label Mar 4, 2023
@Borewit Borewit mentioned this pull request Mar 4, 2023
Comment thread build.gradle Outdated
Comment thread src/main/java/christophedelory/xml/XmlSerializer.java Outdated
Comment thread src/main/java/christophedelory/xml/XmlSerializer.java
Comment thread src/main/java/christophedelory/content/Content.java Outdated
Comment thread src/main/java/christophedelory/content/Content.java
@Borewit
Borewit force-pushed the code-fixes branch 2 times, most recently from 2a3c3e8 to a1469aa Compare March 4, 2023 17:23
@Borewit
Borewit force-pushed the code-fixes branch 3 times, most recently from ad32e15 to e7f994e Compare March 5, 2023 12:59
- Remove unused dependencies
- Simplifies expressions with binary operators
- Remove fully qualified Object references, use import instead
- Remove unnecessary throws
@Borewit
Borewit merged commit cbcf21b into main Mar 5, 2023
@Borewit
Borewit deleted the code-fixes branch March 5, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant