You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Review the renegade (deep, batch) repair function #207
👉🏻 Resolved.
Additional observations:
Build-number added:
For interest's sake, I also ran the repair speed tests again, using the same playlist with 631 broken tracks, as before:
Test 1: For this test, the FLAC plus MP3 Media Directories were added as media sources. Test 2: For this test, the FLAC directory is removed, leaving the MP3 directory as the only media source.
REPAIR ACTION
Test 1: FLAC+MP3
Test 2: MP3 ONLY
Find Exact Matches
1m 09s
0m 29s
Find Closest Matches
5m 17s
2m 42s
Find All Matches
6m 26s
3m 11s
Notably, the aforegoing test results have grown worse by a considerable margin (>30%), over those of previous builds — all which were nearly consistent.
In addition, and this is a purely circumstantial observation, the PC memory (16GB RAM in this instance) usage appears to have worsened, too, while the playlist repair was in progress. Mouse pointer movement became rough/sticky/bumpy, unresponsive, and it is best to wait until all the broken track matches are found before continuing to multitask.
Notably, the aforegoing test results have grown worse by a considerable margin (>30%), over those of previous builds — all which were nearly consistent.
The only explanation I have is that this is the effect of #209, but that you have not been able to measure that correctly because you experiences issue installing the corresponding build. I opened PR #207, which reverse the changes of #209.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #207