Migrate the application init files to JSON by Borewit · Pull Request #19 · Borewit/listFix

Borewit · 2023-01-13T18:14:40Z

Existing .ini files will not be converted.

Migrate the application the following .ini files to .json:
- %USERPFILE%\.listFix()\dirLists.ini with %USERPFILE%\.listFix()\mediaLibrary.json
- %USERPFILE%\.listFix()\history.ini with %USERPFILE%\.listFix()\history.json
- - %USERPFILE%\.listFix()\options.ini with %USERPFILE%\.listFix()\options.json
Removed .ini file conversions

Borewit · 2023-01-13T18:21:23Z

@touwys are you able to test this beta release?

Deleted listFix-2.5.0.zip

Changes are drastic and I have hardly tested anything myself. So expect problems.

touwys · 2023-01-14T05:22:37Z

Thank you, and thank you! I surely will do it, as far as my (very) limited experience allows. It may take a few days however, before I am able to report back.

…

---------------------------------------- 13 Jan 2023 20:21:34 Borewit ***@***.***>:

@touwys[https://github.com/touwys] are you able to test this beta release? listFix-2.5.0.zip[https://github.com/Borewit/listFix/files/10414356/listFix-2.5.0.zip] — Reply to this email directly, view it on GitHub[#19 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/APVPQQWHFECZCDKOIPXZXJ3WSGMK5ANCNFSM6AAAAAAT2V2MWI]. You are receiving this because you were mentioned.[Tracking image][https://github.com/notifications/beacon/APVPQQT6LWXXKSKDBJBTSA3WSGMK5A5CNFSM6AAAAAAT2V2MWKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSSMMD66.gif]

touwys · 2023-01-14T07:54:30Z

I downloaded listFix-2.5.0.zip. Uninstalled v2.4.0.

To which directory do I have to unzip the v2.5.0 folder? Anywhere in particular?

I installed it here: c:/portable/listFix-2.5.0

then proceeded to run "listFix-2.5.0.jar", which I presumed to be the executable, but nothing actuated.

Did I follow the correct steps? Apologies for my ignorance.

Footnote: jre1.8.0_351

Borewit · 2023-01-14T11:08:57Z

There was an issue building the Windows executable, which I have now fixed.
Let me prepare an easier deployment...

Borewit · 2023-01-15T16:53:51Z

@touwys can you also try this beta release: 2.4.1-1?

touwys · 2023-01-15T17:50:57Z

@touwys can you also try this beta release: 2.4.1-1?

Good show! Thank you. 😁

I installed v2.4.1 moments ago, and now I can add the Media and Playlist Directories without a hitch. I will play around some more, and let you know if something else crops up. Meanwhile, keep me posted on what more you want me to do?

(BTW: I emailed the above reply including a screenshot almost immediately after downloading and installing, but failed to display here).

Borewit · 2023-01-15T18:09:42Z

Glad to hear things are working. If you can give me a clear confirmation 2.4.1-1 (which is 2.4.1 + this Pull Request(PR)) is at least as good as 2.4.1. No rush, please take time to test it.

And in the issues you created, #14, #15 if they are resolved with any of those versions. So feedback regarding 2.4.1 is best to place there, because then I know if those issues are resolved or not.

touwys · 2023-01-15T21:16:24Z

Will do. (This time it may indeed take a little while longer, due to our restricted national electrical power supply. It's a nightmare.)

touwys · 2023-01-16T07:28:30Z

@Borewit:

I installed v2.4.1-1 without first uninstalling v2.4.1. The results of the first few quick tests, are as follows:

The Media Directories failed to be added — as it previously did with v2.4.0.
The addition of the default Playlist Directories (in Options) was successful.
The option to change the default app Skin was successful, unlike in v2.4.0 which caused the app to hang.

A clean installation of v2.4.1-1 required? (Possible corruption of config files ini_json?)

touwys · 2023-01-16T08:04:04Z

@Borewit:

I did a clean reinstallation of v2.4.1-1, with the same initial results as already noted.

I have one query, though (also view the screenshot):

How is it possible for a playlist to be verified as "OK" or "!" in the absence of the Media Directories?

touwys · 2023-01-16T09:30:19Z

@Borewit:

You are really swinging it!

listFix() v2.4.2 — The issues that presented in the preceding versions, are now gone. Great job, and fast!

Thank you.

Anything else in particular that you want me to test for?

Borewit · 2023-01-16T11:33:49Z

Thanks for you detailed review @touwys, very useful. Based on your findings on v2.4.1-1, this PR seems to reintroduce issues with adding media directories. I hope I will be able to reproduce those issues.

I did some testing on v2.4.1-1 myself, by fixing some of my playlists. At a certain point I run into an Exception.

Borewit · 2023-01-16T17:35:07Z

@touwys, can you find any issue is this release: beta-v2.4.2-2

Borewit · 2023-01-17T07:54:39Z

I'm sorry, but I'm unable to locate the download link for listFix() beta-v2.4.2-2 on the given page.

My mistake, forgot to submit the page.

Can you perhaps provide a direct download link for it?

Release is to big to toss it into an issue, something like 25MB what is allowed, but yeah can be done with some third party service.

Borewit · 2023-01-29T14:55:51Z

All of navigating GitHub, and the corresponding language used by developers, may come natural to you guys, but believe me, to the uninitiated, this is all a very strange, if confusing experience.

Fully understand that, it is not easy.

"Select Closest Matches" > "Preview" >"Play". Again, now does not call the default player. Perhaps consider to later add an programme Option to select any player?

Ah, preview play within the "Select Closest Matches", yes I can replicate the issue! Sorry I missed that in earlier observations.

"Find Exact Matches" (binocular icon) behaves the same as before — it briefly flashes on the screen what appears to be a progress window that says "Repairing", but it disappears instantly.

Can you please try to create a test environment somewhere on C:\? Copy a bunch of audio files to a test folder, create a playlist from the audio files. Move the files to a sub-directory, to deliberately break the playlist and re-try the "Select Closest Matches".

The goal is to get in working on your machine. If you manage to get in working, we can start to figure out under what condition it breaks.

Borewit · 2023-01-29T14:59:23Z

"Select Closest Matches" > "Preview" >"Play". Again, now does not call the default player. Perhaps consider to later add an programme Option to select any player?

This issue seems to be introduced by this PR.

touwys · 2023-01-29T15:12:28Z

"Select Closest Matches" > "Preview" >"Play". Again, now does not call the default player. Perhaps consider to later add an programme Option to select any player?

This issue seems to be introduced by this PR.

Yes, it worked properly in listFix_2.4.2

touwys · 2023-01-29T15:14:18Z

Can you please try to create a test environment somewhere on C:\? Copy a bunch of audio files to a test folder, create a playlist from the audio files. Move the files to a sub-directory, to deliberately break the playlist and re-try the "Select Closest Matches".

Starting this tomorrow.

Borewit · 2023-01-29T15:23:47Z

This version should fix NullPointerException, when:

Right click on playlist entry, select "Find Closest Matches" > In "Preview" click "Play" button.

listFix_2.4.2-7.exe

touwys · 2023-01-29T15:27:59Z

to deliberately break the playlist and re-try the "Select Closest Matches".

By "Closest Matches", do you mean "Fix Everything?

Borewit · 2023-01-29T15:37:29Z

By "Closest Matches", do you mean "Fix Everything?

Updated #19 (comment).

I copied your words 😉.

touwys · 2023-01-29T16:28:15Z

I copied your words wink.

"Closest Matches" is the heading of the window that opens only once "Fix Everything" is activated, it is not an action in itself... 🤔

Jokes aside, I could not wait, went ahead and installed listFix_2.4.2-7. Copied 21 audio files over to C:\ and created the playlist, which I then broke by moving the audio files to a subfolder. Both "Fix Everything" and "Find Exact Matches" fixed the broken playlist in an instant. "Preview" > "Play" not tested.

Borewit · 2023-01-29T19:56:37Z

"Closest Matches" is the heading of the window that opens only once "Fix Everything" is activated, it is not an action in itself...

What I have fixes in the last update:

This is the play I have fixed, which was broken:

I thought that is what you meant in #19 (comment), ""Select Closest Matches" > "Preview" >"Play"

Remove functionality for old INI file conversions. Replace dependencies on GUIScreen with interfaces.

Prevent directory sets are replaced, to prevent wrong instances being used. Fix bug prompting errors in a loop.

Add initial JUnit5 unit test

touwys · 2023-01-30T05:01:56Z

I thought that is what you meant in #19 (comment), "Select Closest Matches" > "Preview" >"Play"

Yes, that's the one — only, I engaged it from the menu bar (magic wand icon) while you did it from the playlist context menu. Thus, we agree.

I have tested "Select Closest Matches" > "Preview" >"Play", and also found it fixed for listFix_2.4.2-7. It called the default player to play the selected track.

Is fixing "Find Exact Matches" next on the test list?

Borewit · 2023-01-30T07:04:18Z

Is fixing "Find Exact Matches" next on the test list?

Since this issue was already present in v2.4.2 reported here, please create a new issue for this.

I am going to merge the PR, and create a formal release.

touwys · 2023-01-30T07:43:55Z

Since this issue was already present in v2.4.2 reported here, please create a new issue for this.

No problem, but do you mean I have to create an issue other than the same one already posted here?:

The "Find Exact Matches" action appears to be dysfunctional? · Issue #28 · Borewit/listFix

Borewit · 2023-01-30T08:19:31Z

Part of v2.5.0

Borewit · 2023-01-30T10:00:42Z

No problem, but do you mean I have to create an issue other than the same one already posted here?

My bad, no one issue is more then enough.

Borewit added the enhancement Request or implementation of new feature label Jan 13, 2023

Borewit self-assigned this Jan 13, 2023

Borewit force-pushed the migrate-appconfig-to-json branch from ff316e3 to 57324ed Compare January 13, 2023 18:17

Borewit mentioned this pull request Jan 13, 2023

Media Directories Cannot be Added #15

Closed

Borewit force-pushed the migrate-appconfig-to-json branch 3 times, most recently from 42561d8 to c37c983 Compare January 15, 2023 14:29

Borewit force-pushed the main branch 2 times, most recently from 6329f45 to 962067f Compare January 15, 2023 16:01

Borewit force-pushed the migrate-appconfig-to-json branch 2 times, most recently from b14062c to 5ac3160 Compare January 15, 2023 16:45

Borewit force-pushed the migrate-appconfig-to-json branch from 5ac3160 to 59fb7c0 Compare January 15, 2023 18:23

Borewit mentioned this pull request Jan 16, 2023

Upon changing the skin, the app hangs #17

Closed

Borewit added the debt Technical debt label Jan 16, 2023

Borewit force-pushed the migrate-appconfig-to-json branch 2 times, most recently from 0c8a19d to 80a6a96 Compare January 16, 2023 17:06

Borewit mentioned this pull request Jan 29, 2023

Playing a file from a playlists throws an error in VLC #30

Closed

Borewit force-pushed the migrate-appconfig-to-json branch from 939329c to e8b271b Compare January 29, 2023 20:50

Borewit added 7 commits January 29, 2023 22:15

Migrate the application init files to JSON.

4d1cdef

Remove functionality for old INI file conversions. Replace dependencies on GUIScreen with interfaces.

Abstract media library with an interface.

fa71c14

Prevent directory sets are replaced, to prevent wrong instances being used. Fix bug prompting errors in a loop.

Refactor passing playlist configuration

338a002

Fix concurrent access exception in normalizeFileSetToUNC()

b029670

Add initial JUnit5 unit test

Fix PlaylistEntry.play() throwing NullPointerException

09e3c3c

CI: Add CheckStyle to task to CI GitHub Action

731ab85

Removed unused dependency

20840de

Borewit force-pushed the migrate-appconfig-to-json branch from f216f07 to 20840de Compare January 29, 2023 21:15

Revert image

4867aed

Borewit merged commit 5b10eba into main Jan 30, 2023

Borewit deleted the migrate-appconfig-to-json branch January 30, 2023 07:09

This was referenced Jan 30, 2023

The "Find Exact Matches" action appears to be dysfunctional? #28

Closed

Migrate .listFix()\positions.ini to JSON #54

Closed

Borewit mentioned this pull request Nov 15, 2023

Clone the playlist type when creating a new playlist #229

Merged

Conversation

Borewit commented Jan 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Borewit commented Jan 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

touwys commented Jan 14, 2023 via email

Uh oh!

touwys commented Jan 14, 2023 • edited by Borewit Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Borewit commented Jan 14, 2023

Uh oh!

Borewit commented Jan 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

touwys commented Jan 15, 2023 • edited by Borewit Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Borewit commented Jan 15, 2023

Uh oh!

touwys commented Jan 15, 2023

Uh oh!

touwys commented Jan 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

touwys commented Jan 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

touwys commented Jan 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Borewit commented Jan 16, 2023

Uh oh!

Borewit commented Jan 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Borewit commented Jan 17, 2023

Uh oh!

Borewit commented Jan 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Borewit commented Jan 29, 2023

Uh oh!

touwys commented Jan 29, 2023

Uh oh!

touwys commented Jan 29, 2023

Uh oh!

Borewit commented Jan 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

touwys commented Jan 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Borewit commented Jan 29, 2023

Uh oh!

touwys commented Jan 29, 2023

Uh oh!

Borewit commented Jan 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

touwys commented Jan 30, 2023

Uh oh!

Borewit commented Jan 30, 2023

Uh oh!

touwys commented Jan 30, 2023

Uh oh!

Borewit commented Jan 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Borewit commented Jan 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

Borewit commented Jan 13, 2023 •

edited

Loading

Borewit commented Jan 13, 2023 •

edited

Loading

touwys commented Jan 14, 2023 •

edited by Borewit

Loading

Borewit commented Jan 15, 2023 •

edited

Loading

touwys commented Jan 15, 2023 •

edited by Borewit

Loading

touwys commented Jan 16, 2023 •

edited

Loading

touwys commented Jan 16, 2023 •

edited

Loading

touwys commented Jan 16, 2023 •

edited

Loading

Borewit commented Jan 16, 2023 •

edited

Loading

Borewit commented Jan 29, 2023 •

edited

Loading

Borewit commented Jan 29, 2023 •

edited

Loading

touwys commented Jan 29, 2023 •

edited

Loading

Borewit commented Jan 29, 2023 •

edited

Loading

Borewit commented Jan 30, 2023 •

edited

Loading