Skip to content

Be able to drag new media directories into the media-list#147

Merged
Borewit merged 2 commits into
mainfrom
drag-folder-into-media-list
Apr 2, 2023
Merged

Be able to drag new media directories into the media-list#147
Borewit merged 2 commits into
mainfrom
drag-folder-into-media-list

Conversation

@Borewit

@Borewit Borewit commented Mar 31, 2023

Copy link
Copy Markdown
Owner

No description provided.

@Borewit Borewit self-assigned this Mar 31, 2023
@Borewit

Borewit commented Mar 31, 2023

Copy link
Copy Markdown
Owner Author

Build listFix_2.6.0-PR147-44.exe

@touwys

touwys commented Apr 1, 2023

Copy link
Copy Markdown

Review: listFix_2.6.0-PR147-44

👉🏻 Dragging new media directories into the media-directory panel works, but with the following two issues — as per screenshots:

  1. GUI display issue upon change the font style from the default. This is a repeating issue that we are already aware of. It's still to be taken care of, later?

Screenshot 1.


  1. Reminder Dialogue: The applicable action did not perform as intended. Out of the 4 subdirectories that were added by drag & drop, only the first one was removed. The action did not proceed beyond this point, i.e. 3 of 4 listed subdirectories remained visible in the panel, and the main directory containing them, was not added as it should have been. In addition, these 3 remaining directories had to be removed manually, one by one, as multi-select was unavailable.

👉🏻 While you're at this, why not consider adding a "Close/Remove All" keyboard shortcut with which to close all the added media directories, which are currently presented in the in this panel, simultaneously?

Screenshot 2.


@Borewit

Borewit commented Apr 1, 2023

Copy link
Copy Markdown
Owner Author

GUI display issue upon change the font style from the default. This is a repeating issue that we are already aware of. It's still to be taken care of, later?

Then an issue should be raised to address it, it does not belong in this PR.

@touwys

touwys commented Apr 1, 2023

Copy link
Copy Markdown

I was still busy posting when our power supply was cut. Here is the log file, applicable to this review:


rollingfile.log

@Borewit
Borewit force-pushed the drag-folder-into-media-list branch from 51465d7 to a256259 Compare April 1, 2023 11:52
@Borewit

Borewit commented Apr 1, 2023

Copy link
Copy Markdown
Owner Author

Build listFix_2.6.0-PR147-47.exe

@touwys

touwys commented Apr 1, 2023

Copy link
Copy Markdown

Review: listFix_2.6.0-PR147-47

✔️ All good to go!

👍🏻 I do like the way you've streamlined the action by having it auto-remove the preloaded subdirectories as soon as their mother-directory gets dragged onto the media directory panel:

image

❓ May I propose an alternative phrase for the "Reminder" dialogue above? What about this:

Removed 2 media directories duplicated in the directories you have added.


❓ I also noticed a considerable speed increase in the loading of the media directories. Is it my imagination? If not, how did you achieve that?



rollingfile.log

@Borewit

Borewit commented Apr 2, 2023

Copy link
Copy Markdown
Owner Author

❓ May I propose an alternative phrase for the "Reminder" dialogue above? What about this:

I changes it to: "Removed %d duplicated media directories" and I changed the dialog title "Reminder" to "Notification".

❓ I also noticed a considerable speed increase in the loading of the media directories. Is it my imagination? If not, how did you achieve that?

Nothing in this PR what could have increased the speed.

@Borewit
Borewit force-pushed the drag-folder-into-media-list branch from 2e0459f to 20b9ff4 Compare April 2, 2023 13:34
@Borewit
Borewit merged commit 5df3e7a into main Apr 2, 2023
@Borewit
Borewit deleted the drag-folder-into-media-list branch April 2, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants