Improve code style by Borewit · Pull Request #121 · Borewit/listFix

Borewit · 2023-02-27T21:16:33Z

Improve code style of:

MultiListBatchClosestMatchResultsDialog.java
PlaylistEditCtrl.java
Resolved 156 code smells:

sonatype-lift · 2023-02-27T22:29:30Z

+    return button;
+  }
+
+  private void onBtnLocateActionPerformed(java.awt.event.ActionEvent evt)


UnusedMethod: Method 'onBtnLocateActionPerformed' is never used.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-27T22:29:32Z


-  private void onMenuEditFilenameActionPerformed(java.awt.event.ActionEvent evt)//GEN-FIRST:event_onMenuEditFilenameActionPerformed
-  {//GEN-HEADEREND:event_onMenuEditFilenameActionPerformed
+  private void onMenuEditFilenameActionPerformed(java.awt.event.ActionEvent evt)


UnnecessarilyFullyQualified: This fully qualified name is unambiguous to the compiler if imported.

Suggested change

private void onMenuEditFilenameActionPerformed(java.awt.event.ActionEvent evt)

private void onBtnLocateActionPerformed(ActionEvent evt)

❗❗ 4 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

src/main/java/listfix/view/controls/PlaylistEditCtrl.java 846

src/main/java/listfix/view/controls/PlaylistEditCtrl.java 861

src/main/java/listfix/view/controls/PlaylistEditCtrl.java 851

src/main/java/listfix/view/controls/PlaylistEditCtrl.java 838

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-27T22:29:35Z

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.¹

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/Borewit/listFix/121.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/Borewit/listFix/121.diff | git apply

Once you're satisfied, commit and push your changes in your project.

You can preview the patch by opening the patch URL in the browser. ↩

sonatype-lift · 2023-02-27T22:49:43Z

          }
        }
-        catch (InterruptedException ex)
+        catch (InterruptedException ignored)


EmptyCatch: Caught exceptions should not be ignored

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Borewit added the internal Excluded from release notes label Feb 27, 2023

Borewit self-assigned this Feb 27, 2023

Borewit force-pushed the codeStyle branch from da04f34 to 8d25b9f Compare February 27, 2023 22:23

Borewit changed the title ~~Improve code style MultiListBatchClosestMatchResultsDialog~~ Improve code style Feb 27, 2023

Borewit force-pushed the codeStyle branch from 8d25b9f to a08e4c3 Compare February 27, 2023 22:24

sonatype-lift Bot reviewed Feb 27, 2023

View reviewed changes

Improve code style

07e264b

Borewit force-pushed the codeStyle branch 2 times, most recently from 0441691 to d737dac Compare February 27, 2023 22:44

sonatype-lift Bot reviewed Feb 27, 2023

View reviewed changes

Improve codestyle PlaylistEditCtrl

64e0905

Borewit force-pushed the codeStyle branch from d737dac to 64e0905 Compare February 28, 2023 07:49

Borewit merged commit 0df6382 into main Feb 28, 2023

Borewit deleted the codeStyle branch February 28, 2023 09:47

midmarch mentioned this pull request Feb 28, 2023

Open file location of best match #106

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve code style#121

Improve code style#121
Borewit merged 2 commits into
mainfrom
codeStyle

Borewit commented Feb 27, 2023 •

edited

Loading

Uh oh!

sonatype-lift Bot Feb 27, 2023

Uh oh!

sonatype-lift Bot Feb 27, 2023

Uh oh!

sonatype-lift Bot commented Feb 27, 2023

Uh oh!

sonatype-lift Bot Feb 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

	private void onMenuEditFilenameActionPerformed(java.awt.event.ActionEvent evt)
	private void onBtnLocateActionPerformed(ActionEvent evt)

File Path	Line Number
src/main/java/listfix/view/controls/PlaylistEditCtrl.java	846
src/main/java/listfix/view/controls/PlaylistEditCtrl.java	861
src/main/java/listfix/view/controls/PlaylistEditCtrl.java	851
src/main/java/listfix/view/controls/PlaylistEditCtrl.java	838

Conversation

Borewit commented Feb 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonatype-lift Bot Feb 27, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot Feb 27, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot commented Feb 27, 2023

🛠 Lift Auto-fix

Footnotes

Uh oh!

sonatype-lift Bot Feb 27, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Borewit commented Feb 27, 2023 •

edited

Loading