Skip to content

Be able to drag playlist folders into Playlists-Directories panel#113

Merged
Borewit merged 1 commit into
mainfrom
drag-folder-into-playlists-directories
Feb 27, 2023
Merged

Be able to drag playlist folders into Playlists-Directories panel#113
Borewit merged 1 commit into
mainfrom
drag-folder-into-playlists-directories

Conversation

@Borewit

@Borewit Borewit commented Feb 25, 2023

Copy link
Copy Markdown
Owner

If allow to any file type onto the Playlists-Directories component.

When these files are dropped, I will filter out folders to be added. When there is one or more folder in the file list, the drag is reported back as successful, otherwise not.

Resolves #105

@Borewit Borewit added the enhancement Request or implementation of new feature label Feb 25, 2023
@Borewit Borewit self-assigned this Feb 25, 2023
@Borewit

Borewit commented Feb 25, 2023

Copy link
Copy Markdown
Owner Author

Build: listFix_2.6.0-PR113-5.exe

@Borewit
Borewit force-pushed the drag-folder-into-playlists-directories branch from eee1668 to 276c8c6 Compare February 26, 2023 12:27
@touwys

touwys commented Feb 27, 2023

Copy link
Copy Markdown

Test Results listFix_2.6.0-PR113-5

1. Drag & drop several playlist folders into the PLD, works as intended.

1.1 But, why then exclude support for the "Drag and Drop" operation for a selection of individual playlists direct from their location, too?

2. Go to File / Options / Theme: After changing to a new theme, all the tab-titles in the PLE disappear (go blank).


listFix_2 6 0-PR113-5 _ blank tab-tiles after changing theme _ Screenshot

@Borewit

Borewit commented Feb 27, 2023

Copy link
Copy Markdown
Owner Author

1.1 But, why then exclude support for the "Drag and Drop" operation for a selection of individual playlists direct from their location, too?

If you drag it will "accept" any file type, as I believe I can only determine you want to drop a file list (a single file is also provided as a file list).

When you drop, I filter out folders to be added. When there is one or more folder in the file list, the drag is reported back as successful, otherwise not. Not sure what the effect of non successful drop is, maybe OS specific.

@touwys

touwys commented Feb 27, 2023

Copy link
Copy Markdown

If you drag it will "accept" any file type, as I believe I can only determine you want to drop a file list (a single file is also provided as a file list).

Are you saying that it does support dragging and dropping of selected playlists from their location — as distinguished from those playlist getting added to the PLD in their folder? If so, it did not work for me while testing this release.


When you drop, I filter out folders to be added. When there is one or more folder in the file list, the drag is reported back as successful, otherwise not. Not sure what the effect of non successful drop is, maybe OS specific.

👍🏻 During my test, I was able to drag and drop single, or multiple selected playlist folders to the PLD. Have seen none unsuccessful.


@Borewit

Borewit commented Feb 27, 2023

Copy link
Copy Markdown
Owner Author

Have seen none unsuccessful.

Let's merge this one.

@Borewit
Borewit merged commit 0f6f29f into main Feb 27, 2023
@touwys

touwys commented Feb 27, 2023

Copy link
Copy Markdown

Let's merge this one.

Yes. Should I add support for drag and drop playlists to Issues?

@touwys

touwys commented Feb 27, 2023

Copy link
Copy Markdown

Yes. Should I add support for drag and drop playlists to Issues?

Submitted, please delete if superfluous.

@touwys

touwys commented Feb 27, 2023

Copy link
Copy Markdown

Just now, discovered another issue with listFix_2.6.0-PR113-5:

Steps:

1. Start listFix, and first thing open multiple playlist into PLE from a folder in the PLD.

2. Go to File / Options / Theme and change the default.

2.1 ListFix() hangs, and has to be forcefully closed.

🤔 The same behaviour was reported for listFix_2.6.0-PR111-5 ?

@Borewit
Borewit deleted the drag-folder-into-playlists-directories branch February 27, 2023 13:59
@Borewit

Borewit commented Feb 27, 2023

Copy link
Copy Markdown
Owner Author

Yes. Should I add support for drag and drop playlists to Issues?

Sure, but that for files dragged onto the (playlist editor pane) I suppose?

@Borewit Borewit mentioned this pull request Mar 31, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Request or implementation of new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Be able to drag folders into Playlists-Directories panel

2 participants