Adjust total progress based on partial task progress by Borewit · Pull Request #111 · Borewit/listFix

Borewit · 2023-02-25T10:55:24Z

Updates the overall progress-bar based on the progress of the sub-task bar
Progress is added over the task is complete instead of before

Resolves #109

Borewit · 2023-02-25T10:58:03Z

sonatype-lift · 2023-02-26T12:31:01Z

-    {
-      progress.setTotal(winLists.size());
-    }
+    progress.setTotal(winLists.size());


NULL_DEREFERENCE: object winLists last assigned on line 93 could be null and is dereferenced at line 94.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-26T12:31:03Z

+  private javax.swing.JButton _cancelButton;
+  private javax.swing.JPanel _middlePanel;
+  private javax.swing.JLabel _overallLabel;
+  private javax.swing.JProgressBar _overallProgress;


UnnecessarilyFullyQualified: This fully qualified name is unambiguous to the compiler if imported.

Suggested change

private javax.swing.JProgressBar _overallProgress;

_taskProgress = new JProgressBar();

❗❗ 6 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

src/main/java/listfix/view/dialogs/DualProgressDialog.java 186

src/main/java/listfix/view/dialogs/DualProgressDialog.java 184

src/main/java/listfix/view/dialogs/DualProgressDialog.java 182

src/main/java/listfix/view/dialogs/DualProgressDialog.java 181

src/main/java/listfix/view/dialogs/DualProgressDialog.java 183

src/main/java/listfix/view/dialogs/DualProgressDialog.java 187

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-26T12:31:05Z

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.¹

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/Borewit/listFix/111.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/Borewit/listFix/111.diff | git apply

Once you're satisfied, commit and push your changes in your project.

You can preview the patch by opening the patch URL in the browser. ↩

sonatype-lift · 2023-02-26T17:05:53Z


-public class DualProgressDialog extends javax.swing.JDialog
+/**
+ * @param <T> the result type returned by this SwingWorker's doInBackground and get methods


MissingSummary: A summary line is required on public/protected Javadocs.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-26T17:05:55Z


-  private void formWindowClosing(java.awt.event.WindowEvent evt)//GEN-FIRST:event_formWindowClosing
-  {//GEN-HEADEREND:event_formWindowClosing
+  private void formWindowClosing(java.awt.event.WindowEvent evt)


UnnecessarilyFullyQualified: This fully qualified name is unambiguous to the compiler if imported.

Suggested change

private void formWindowClosing(java.awt.event.WindowEvent evt)

public void windowClosing(WindowEvent evt)

❗❗ 68 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

src/main/java/listfix/view/dialogs/DualProgressDialog.java 122

src/main/java/listfix/view/dialogs/BatchExactMatchesResultsDialog.java 202

src/main/java/listfix/view/dialogs/BatchExactMatchesResultsDialog.java 155

src/main/java/listfix/view/dialogs/BatchExactMatchesResultsDialog.java 221

src/main/java/listfix/view/dialogs/DualProgressDialog.java 71

src/main/java/listfix/view/dialogs/BatchExactMatchesResultsDialog.java 200

src/main/java/listfix/view/dialogs/DualProgressDialog.java 113

src/main/java/listfix/view/dialogs/DualProgressDialog.java 101

src/main/java/listfix/view/dialogs/BatchExactMatchesResultsDialog.java 293

src/main/java/listfix/view/dialogs/BatchExactMatchesResultsDialog.java 168

Showing 10 of 68 findings. Visit the Lift Web Console to see all.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

touwys · 2023-02-27T08:57:03Z

Build: listFix_2.6.0-PR111-5.exe

Test Results listFix_2.6.0-PR111-5

Playlist tab-titles disappear. These 3 Tab-titles/text went blank after a while. (Two of the playlists were added from the PLD, and one playlist was added to the editor via menu File / Open playlist)

•
listFix_2 6 0-PR111-5 _ blank playlist tab-titles _ Screenshot
•

Changing File / Option / Theme to "Darkstar": It renders Tab-titles of the playlist in the PLE completely blank.

•
listFix_2 6 0-PR111-5 _ blank playlist tab-titles _ Darkstar theme _ Screenshot
•

Changing File / Option / Theme hangs the app. After force closing the app, it was restarted and the File / Option / Theme then worked properly, i.e. without hanging the app.
NB: Check to verify that this operation is working as intended: Append file or playlist — That is, by activating the +sign on the PLE toolbar.

touwys · 2023-02-27T09:00:26Z

Build: listFix_2.6.0-PR111-5.exe

Test Results listFix_2.6.0-PR111-5

1. Playlist tab-titles disappear. These 3 Tab-titles/text went blank after a while. (Two of the playlists were added from the PLD, and one playlist was added to the editor via menu File / Open playlist)

•
listFix_2 6 0-PR111-5 _ blank playlist tab-titles _ Screenshot
•

2. Changing File / Option / Theme to "Darkstar": It renders Tab-titles of the playlist in the PLE completely blank.

•
listFix_2 6 0-PR111-5 _ blank playlist tab-titles _ Darkstar theme _ Screenshot
•

3. Changing File / Option / Theme hangs the app. After force closing the app, it was restarted and the File / Option / Theme then worked properly, i.e. without hanging the app.

4. NB: Check to verify that this operation is working as intended: Append file or playlist (+sign_ on the PLE toolbar)

sonatype-lift · 2023-02-27T10:05:01Z


-  private void formWindowClosing(java.awt.event.WindowEvent evt)//GEN-FIRST:event_formWindowClosing
-  {//GEN-HEADEREND:event_formWindowClosing
+  private void formWindowClosing(java.awt.event.WindowEvent ignore)


UnnecessarilyFullyQualified: This fully qualified name is unambiguous to the compiler if imported.

Suggested change

private void formWindowClosing(java.awt.event.WindowEvent ignore)

public void windowClosing(WindowEvent evt)

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-27T15:31:10Z

 * You can override private methods, but you can't call private methods in the parent class :(
 */
-public class PLSProperties extends Hashtable<Object, Object>
+public class PLSProperties extends Hashtable<String, String>


JdkObsolete: Hashtable performs synchronization this is usually unnecessary; prefer LinkedHashMap.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-27T15:31:13Z

      writeComments(bw, comments);
    }
-    bw.write("#" + new Date().toString());
+    bw.write("#" + new Date());


JavaUtilDate: Date has a bad API that leads to bugs; prefer java.time.Instant or LocalDate.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Borewit added the improvement label Feb 25, 2023

Borewit self-assigned this Feb 25, 2023

Borewit force-pushed the improve-dual-progress-bar branch from ba800e8 to b15c85f Compare February 26, 2023 12:25

sonatype-lift Bot reviewed Feb 26, 2023

View reviewed changes

Borewit force-pushed the improve-dual-progress-bar branch 3 times, most recently from 93c3200 to ea97a2d Compare February 26, 2023 17:01

sonatype-lift Bot reviewed Feb 26, 2023

View reviewed changes

Borewit force-pushed the improve-dual-progress-bar branch 2 times, most recently from 9200042 to e31b796 Compare February 27, 2023 09:59

sonatype-lift Bot reviewed Feb 27, 2023

View reviewed changes

Comment thread src/main/java/listfix/io/WinampHelper.java

Borewit force-pushed the improve-dual-progress-bar branch 4 times, most recently from 7f1481e to d1ce250 Compare February 27, 2023 15:14

Adjust total progress based on partial task progress

7a7db82

Borewit force-pushed the improve-dual-progress-bar branch from d1ce250 to 7a7db82 Compare February 27, 2023 15:25

sonatype-lift Bot reviewed Feb 27, 2023

View reviewed changes

Borewit merged commit cb6520d into main Feb 27, 2023

Borewit deleted the improve-dual-progress-bar branch February 27, 2023 15:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adjust total progress based on partial task progress#111

Adjust total progress based on partial task progress#111
Borewit merged 1 commit into
mainfrom
improve-dual-progress-bar

Borewit commented Feb 25, 2023

Uh oh!

Borewit commented Feb 25, 2023

Uh oh!

sonatype-lift Bot Feb 26, 2023

Uh oh!

sonatype-lift Bot Feb 26, 2023

Uh oh!

sonatype-lift Bot commented Feb 26, 2023

Uh oh!

sonatype-lift Bot Feb 26, 2023

Uh oh!

sonatype-lift Bot Feb 26, 2023

Uh oh!

touwys commented Feb 27, 2023

Uh oh!

touwys commented Feb 27, 2023

Uh oh!

sonatype-lift Bot Feb 27, 2023

Uh oh!

Uh oh!

sonatype-lift Bot Feb 27, 2023

Uh oh!

sonatype-lift Bot Feb 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

	private javax.swing.JProgressBar _overallProgress;
	_taskProgress = new JProgressBar();

File Path	Line Number
src/main/java/listfix/view/dialogs/DualProgressDialog.java	186
src/main/java/listfix/view/dialogs/DualProgressDialog.java	184
src/main/java/listfix/view/dialogs/DualProgressDialog.java	182
src/main/java/listfix/view/dialogs/DualProgressDialog.java	181
src/main/java/listfix/view/dialogs/DualProgressDialog.java	183
src/main/java/listfix/view/dialogs/DualProgressDialog.java	187

	private void formWindowClosing(java.awt.event.WindowEvent evt)
	public void windowClosing(WindowEvent evt)

File Path	Line Number
src/main/java/listfix/view/dialogs/DualProgressDialog.java	122
src/main/java/listfix/view/dialogs/BatchExactMatchesResultsDialog.java	202
src/main/java/listfix/view/dialogs/BatchExactMatchesResultsDialog.java	155
src/main/java/listfix/view/dialogs/BatchExactMatchesResultsDialog.java	221
src/main/java/listfix/view/dialogs/DualProgressDialog.java	71
src/main/java/listfix/view/dialogs/BatchExactMatchesResultsDialog.java	200
src/main/java/listfix/view/dialogs/DualProgressDialog.java	113
src/main/java/listfix/view/dialogs/DualProgressDialog.java	101
src/main/java/listfix/view/dialogs/BatchExactMatchesResultsDialog.java	293
src/main/java/listfix/view/dialogs/BatchExactMatchesResultsDialog.java	168

Conversation

Borewit commented Feb 25, 2023

Uh oh!

Borewit commented Feb 25, 2023

Uh oh!

sonatype-lift Bot Feb 26, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot Feb 26, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot commented Feb 26, 2023

🛠 Lift Auto-fix

Footnotes

Uh oh!

sonatype-lift Bot Feb 26, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot Feb 26, 2023

Choose a reason for hiding this comment

Uh oh!

touwys commented Feb 27, 2023

Uh oh!

touwys commented Feb 27, 2023

Uh oh!

sonatype-lift Bot Feb 27, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonatype-lift Bot Feb 27, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot Feb 27, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants