feat: populate external outputs in lwk#505
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
jackstar12
force-pushed
the
feat/lwk-external-outputs
branch
from
77a1c04 to
c55bd8d
Compare
michael1011
reviewed
Jul 14, 2025
Comment on lines
+386
to
+396
| if maybeOutput == nil { | ||
| if address := output.UnconfidentialAddress(convertNetwork(w.backend.cfg.Network)); address != nil { | ||
| result.Address = (*address).String() | ||
| } | ||
| if amount := output.Value(); amount != nil { | ||
| result.Amount = *amount | ||
| } | ||
| } else { | ||
| result.Address = (*maybeOutput).Address().String() | ||
| result.Amount = (*maybeOutput).Unblinded().Value() | ||
| result.IsOurAddress = true |
Member
There was a problem hiding this comment.
How should we treat non L-BTC outputs?
Member
Author
There was a problem hiding this comment.
Have them amount 0? We only wanna deal with BTC
michael1011
approved these changes
Jul 15, 2025
| require.True(t, slices.ContainsFunc(tx.Outputs, func(o onchain.TransactionOutput) bool { | ||
| return o.Address == addressInfo.Address | ||
| })) | ||
| fee := int64(tx.Outputs[len(tx.Outputs)-1].Amount) |
Member
There was a problem hiding this comment.
Checking for the script pubkey having 0 length would be more robust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.