Skip to content

Conversation

@cssjoe
Copy link
Member

@cssjoe cssjoe commented Aug 13, 2025

When Page Cache is flushed and Elementor is active, the Elementor cache is flushed. This update flushes the Object Cache after the Elementor cache is flushed.

Prerequisites:

  • W3TC 2.8.11 with Page Cache and Object Cache enabled

To test:

  1. Checkout the master branch (without the fix)
  2. Install Elementor
  3. Activate an Elementor theme, such as "Hello Biz"
  4. Create a new page using Elementor
  5. Open the new page in Incognito/Private Browsing
  6. In the wp-admin panel, go to Elementr Tools (wp-admin/admin.php?page=elementor-tools) and click "Clear Files & Data"
  7. In the admin bar, click Perfornance >> Purge All Caches
  8. Hard-refresh the new page to see that the page has style issue
  9. Checkout this ENG5-326-dev branch
  10. In the wp-admin panel, go to Elementr Tools (wp-admin/admin.php?page=elementor-tools) and click "Clear Files & Data"
  11. In the admin bar, click Perfornance >> Purge All Caches
  12. Hard-refresh the new page to see that the page appears ok

@cssjoe cssjoe added this to the 2.8.12 milestone Aug 13, 2025
@cssjoe cssjoe self-assigned this Aug 13, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a caching issue in WordPress sites using Elementor by ensuring that the Object Cache is flushed after Elementor's file manager cache is cleared during a full cache flush operation.

  • Adds Object Cache flush after Elementor cache flush to prevent style issues
  • Includes explanatory comments for both Elementor and Object Cache flush operations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 1.45%. Comparing base (a37185e) to head (cc29d52).

Files with missing lines Patch % Lines
CacheFlush.php 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1158      +/-   ##
===========================================
- Coverage      1.45%   1.45%   -0.01%     
  Complexity    19516   19516              
===========================================
  Files           634     634              
  Lines         98307   98308       +1     
===========================================
  Hits           1429    1429              
- Misses        96878   96879       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <[email protected]>
@cssjoe cssjoe merged commit e05a458 into master Aug 14, 2025
2 checks passed
@cssjoe cssjoe deleted the ENG5-326-dev branch August 14, 2025 14:55
@cssjoe cssjoe removed the request for review from jacobd91 August 14, 2025 16:15
@cssjoe cssjoe added the bug Something isn't working label Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants