ENG5-45 #1118
Merged
ENG5-45 #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This was
linked to
issues
Jun 30, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1118 +/- ##
========================================
Coverage 1.28% 1.28%
- Complexity 19502 19506 +4
========================================
Files 633 633
Lines 98306 98314 +8
========================================
+ Hits 1263 1268 +5
- Misses 97043 97046 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Adds a new helper to detect Elementor and integrates Elementor cache clearing into the global flush routine, plus updates documentation.
- Adds
Util_Environment::is_elementor()to check if Elementor is active - Extends
CacheFlush::flush_all()to clear Elementor’s cache before flushing - Updates
readme.txtto list a new contributor
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| readme.txt | Added "elanasparkle" to Contributors; removed leading hyphen |
| Util_Environment.php | New is_elementor() method to detect Elementor plugin |
| CacheFlush.php | Calls Elementor’s cache clear in flush_all() |
Comments suppressed due to low confidence (4)
readme.txt:2
- The leading hyphen was removed from the Contributors list item, which may break markdown list formatting. Consider restoring the
-prefix for consistency.
Contributors: boldgrid, fredericktownes, maxicusc, gidomanders, bwmarkle, harryjackson1221, joemoto, vmarko, jacobd91, avonville1, jamesros161, elanasparkle
Util_Environment.php:377
- The function
is_plugin_active()is defined inwp-admin/includes/plugin.phpand may not be available; include it or wrap this call infunction_exists('is_plugin_active')to avoid a fatal error.
if ( is_plugin_active( 'Elementor\Plugin' ) ) {
Util_Environment.php:377
- The
is_plugin_activefunction expects a plugin file path like'elementor/elementor.php', not a class name; useclass_exists('\Elementor\Plugin')or the correct file path instead.
if ( is_plugin_active( 'Elementor\Plugin' ) ) {
CacheFlush.php:228
- Accessing the static
$instanceproperty directly can break if it’s protected; use\Elementor\Plugin::instance()->files_manager->clear_cache()and match the correct namespace casing.
\elementor\Plugin::$instance->files_manager->clear_cache();
Contributor
Author
jamesros161
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.