Skip to content

Conversation

@jamesros161
Copy link
Collaborator

ISSUE: Resolves #608

Fix multi-sliders not changing min/max/step slider options on unit change

Test Files

post-and-page-builder-1.27.4-issue-608.zip

NOTES TO TESTER

Please leave comments regarding issues found in testing directly on the issue linked above, not the Pull Request. This helps ease the process of reviewing the testing of multiple PRs in a given project from the project view.

Please remember to move this item from 'Needs Review' to either 'In Progress' or 'Awaiting Release' depending on the results of your testing

Testing Instructions

  1. Install the test zip files linked above.
  2. Open a page and add a block if needed for content
  3. Open the Row popover and click Advanced Controls
  4. Click on Border Radius - see how the sliders for PX and EM go to a max value of 50, with 1px steps.
  5. Set a pixel value on the slider.
  6. Change the unit to EM, and ensure that the PX unit is converted, and that the slider max value is now 5, with 1px steps.

@jamesros161 jamesros161 merged commit 75fcd12 into master Dec 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Max input goes from 50 to 5 after closing and reopening same panel

3 participants