Skip to content

Conversation

@jamesros161
Copy link
Collaborator

ISSUE: Resolves #624

Fix section divider colors on CPH & Sticky Header

Test Files

post-and-page-builder-1.27.2-issue-624.zip

NOTES TO TESTER

Please leave comments regarding issues found in testing directly on the issue linked above, not the Pull Request. This helps ease the process of reviewing the testing of multiple PRs in a given project from the project view.

Please remember to move this item from 'Needs Review' to either 'In Progress' or 'Awaiting Release' depending on the results of your testing

Testing Instructions

  1. Install the test zip files linked above.
  2. Install an inspiration with a section divider ( in the testing the DH Dog Care theme was used )
  3. Add a sticky header in the customizer, but change the sticky header background to a color other than the color used by the section divider ( in this case the color set to color-2 )
  4. Verify that the section divider keeps the correct color instead of taking the color of the sticky header.

@nicolepaschen
Copy link
Member

looks good

@jamesros161 jamesros161 changed the base branch from master to branch-1.27.2 October 8, 2024 18:32
@jamesros161 jamesros161 merged commit 81218a6 into branch-1.27.2 Oct 8, 2024
@jamesros161 jamesros161 deleted the issue-624 branch October 8, 2024 18:32
jamesros161 added a commit that referenced this pull request Oct 9, 2024
* update version and readme

* resolves #624 (#625)

* add extra padding to iframe (#623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CPH with Section divider & Sticky Header conflict

4 participants