fix neutral colors not being removed from elements #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avonville
reviewed
Oct 19, 2023
| transparentColors: [ 'rgba(0, 0, 0, 0)', 'transparent' ], | ||
|
|
||
| colorClasses: [ 'color1-color', 'color2-color', 'color3-color', 'color4-color', 'color5-color' ], | ||
| colorClasses: [ 'color1-color', 'color2-color', 'color3-color', 'color4-color', 'color5-color', 'color-neutral-color' ], |
There was a problem hiding this comment.
Any reason this is on a single line when the others are separated? Not a big deal, I am assuming is just based on the amount of values in the array.
Collaborator
Author
There was a problem hiding this comment.
it's based on the amount of space the line takes up. Since they all fit without making the line too long, I left it as one line
avonville
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE: Resolves #527
PROJECT: #14
Color Neutral doesn't get removed when a new color is selected
Test Files
post-and-page-builder-1.25.1-issue-527.zip
NOTES TO TESTER
Please leave comments regarding issues found in testing directly on the issue linked above, not the Pull Request. This helps ease the process of reviewing the testing of multiple PRs in a given project from the project view.
Please remember to move this item from 'Needs Review' to either 'In Progress' or 'Awaiting Release' depending on the results of your testing
Testing Instructions