Skip to content

Conversation

@jamesros161
Copy link
Collaborator

@jamesros161 jamesros161 commented Apr 10, 2023

ISSUE: Resolves #459
Resolves #512

NOTE: Both issues were caused by the same root issue, that the style border-width:0px was being added to new elements unnecessarily. Therefore, both issues are being resolved in the same PR. This issue was being caused by the @boldgrid/controls repository. See commit #1f299be

PROJECT: PPB 1.23.1

Fix border issues with newly added components

Test Files

post-and-page-builder.zip

NOTES TO TESTER

Please leave comments regarding issues found in testing directly on the issue linked above, not the Pull Request. This helps ease the process of reviewing the testing of multiple PRs in a given project from the project view.

Please remember to move this item from 'Needs Review' to either 'In Progress' or 'Awaiting Release' depending on the results of your testing

Testing Instructions

  1. Install the test zip files linked above.
  2. Add a new component. Specifically ensure you test with Buttons, as these were one specifically reported issue.
  3. Ensure that the new component does not have the border-width: 0px inline style added. If testing primary or secondary theme buttons, skip steps 4-6.
  4. Open the advanced control panel for the new element, and go to the 'border' controls
  5. Ensure that the border style is shown as 'None'
  6. Set a border style, and a border width.
  7. Save & publish.
  8. View the page on the front end and ensure the border is visible.
  9. When testing a button, if the button border is not visible ( due to the button styling set in the Crio Customizer ), open the customizer, and configure the associated button class ( primary or secondary ) to show the border, and ensure that it shows as expected.

@jamesros161 jamesros161 merged commit 68ba959 into branch-1.23.1 Apr 12, 2023
@jamesros161 jamesros161 deleted the issue-459-512 branch April 12, 2023 16:36
@jamesros161 jamesros161 mentioned this pull request Apr 12, 2023
jamesros161 added a commit that referenced this pull request Apr 13, 2023
* update @boldgrid/components (#524)

* remove 'Used Blocks' from GridBlocks (#523)

* update readme and version for rc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Border visual bug in admin border-width: 0 added to elements randomly

3 participants