Skip to content

Conversation

@jamesros161
Copy link
Collaborator

@jamesros161 jamesros161 commented Oct 18, 2022

Resolves #158
Resolves #415
Resolves #426
Resolves #460

Testing Instructions

Testing instructions for each issue are included in their respective PRs listed below. Test the issues using the 1.21.3-rc1 test zip below.

post-and-page-builder-1.21.3-rc1

Issue #158 => PR#464
Issue #415 => PR#465
Issue #426 => PR#470
Issue #460 => PR#469

* adjust menu button classes to display correctly

* adjust button classes
* add back gradient controls

* fix gradient preview
* improve RTL functionality

* update version number

* fix additional styles for RTL display
@nicolepaschen
Copy link
Member

nicolepaschen commented Oct 18, 2022

The menu link color does not match what is set in the Customizer. Further testing shows it's ONLY the blog link .... blog link inherits the active link style from the Customizer inside the editor for some reason. Happens in the header too - blog gets active link color.

Also I'm fine with the hover effect NOT showing in the editor, I think it's messing with the row padding controls. https://github.com/BoldGrid/crio-premium/issues/98

menu-link-color-doesnt-match

@nicolepaschen
Copy link
Member

RTL - sorry I think I missed this yesterday but the section popover is cut off
Screenshot_1

@nicolepaschen
Copy link
Member

RTL - I think the editor is struggling to know what screen size I'm actually on. I'm on small desktop but the heading hides when I click tablet as well as desktop
both

@jamesros161 jamesros161 merged commit a778a48 into master Oct 19, 2022
@jamesros161 jamesros161 deleted the branch-1.21.3 branch October 19, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants