Skip to content

Conversation

@jessecowens
Copy link
Member

Resolves #195 @bwmarkle or @rramo012 can you review and release?

Resolves #195 @bwmarkle or @rramo012 can you review and release?
@bwmarkle
Copy link
Contributor

@jamesros161 can you take a look?

@jessecowens do you have some quick testing instructions?

@jessecowens
Copy link
Member Author

@bwmarkle we couldn't determine what about the user's saved/used blocks was causing the null value for post_content, so we couldn't replicate the problem independent of the user's site.

The one thing that jumps out to me is that there was a BoldGrid Block that the user created with Gutenberg and saved it with the post_status "pending."

[quacke5@biz142 public_html]$ wp post list --post_type=bg_block
+-----+--------------------------+-----------------------+---------------------+-------------+
| ID  | post_title               | post_name             | post_date           | post_status |
+-----+--------------------------+-----------------------+---------------------+-------------+
| 703 | Colognes                 |                       | 2021-07-13 16:27:30 | pending     |

This post status isn't accounted for in get_pages, but the way I read it that only means it shouldn't be included in the list at all. In any case, I tried to replicate with a "pending" bg_block and could not trigger the error.

@jessecowens
Copy link
Member Author

It might be worth noting that the user's website was on PHP 8. I couldn't replicate the issue with a backup in CWP, so it might be limited to PHP 8

Copy link
Member Author

@jessecowens jessecowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we could check for empty value at line 61, so the parse_gridblocks function is safer to use from anywhere

@jamesros161 jamesros161 changed the base branch from master to branch-1.14.1 August 25, 2021 17:20
@jamesros161 jamesros161 merged commit b9560df into branch-1.14.1 Aug 25, 2021
@jamesros161 jamesros161 deleted the jessecowens-patch-1 branch July 12, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fatal Error fetching Saved Blocks

4 participants