Fix scheduled jobs not running, and add extra logging #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwmarkle
requested changes
Feb 18, 2025
bwmarkle
requested changes
Feb 24, 2025
bwmarkle
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #612
The issue turned out to caused by a previous commit: 710cb88
This change was made to remove the cron if there are no scheduled jobs to keep it from running unnecessarily.
However, this didn't account for the fact that when new jobs are added to the list of scheduled jobs, the cron entry
isn't being re-added. This PR will add the cron entry if it doesn't already exist, anytime a job is added to the list of scheduled jobs.
Additionally, I am adding a table to the Total Upkeep > Tools > Cron Log that will display the list of currently scheduled jobs.
As for adding a log entry for anytime the settings are changed, that is already present under Total Upkeep > Tools > History
Added a
jobs-queuelog file, that logs when a job is added, running, and deleted.