Skip to content

Comments

Mysql dump charset fixes #252#287

Closed
bwmarkle wants to merge 6 commits into1.13.5-branchfrom
mysql-dump-charset
Closed

Mysql dump charset fixes #252#287
bwmarkle wants to merge 6 commits into1.13.5-branchfrom
mysql-dump-charset

Conversation

@bwmarkle
Copy link
Contributor

@bwmarkle bwmarkle requested a review from cssjoe May 28, 2020 18:47
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2020

Codecov Report

Merging #287 into 1.13.5-branch will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             1.13.5-branch     #287      +/-   ##
===================================================
+ Coverage            24.54%   24.57%   +0.02%     
- Complexity            2680     2681       +1     
===================================================
  Files                  190      190              
  Lines                13060    13064       +4     
===================================================
+ Hits                  3206     3210       +4     
  Misses                9854     9854              
Impacted Files Coverage Δ Complexity Δ
admin/class-boldgrid-backup-admin-db-dump.php 59.13% <100.00%> (+1.83%) 23.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5f2a27...b89e1d2. Read the comment docs.

@bwmarkle
Copy link
Contributor Author

bwmarkle commented Jun 1, 2020

Just adding some notes to this PR...

image

@bwmarkle bwmarkle closed this Jun 1, 2020
@cssjoe cssjoe deleted the mysql-dump-charset branch June 1, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants