Fix bugs, crashes, update 'your library' page & more#22
Fix bugs, crashes, update 'your library' page & more#22BobbyESP merged 17 commits intoBobbyESP:masterfrom Outlet7493:master
Conversation
…nd picture is only color
|
Hi! First of all I want to thank you for the hard work in the project :). It's really nice to see people interested on helping, for real. Leaving that at one side, I will be taking a look to the PR changes this afternoon (if I have time since I'm with exams) for reviewing all the changes. If all it's good I will merge the PR in the main branch and, after that, the next step will be migrating to Media3 and rebuild the playback system since it's kinda broken 😂. It works, but not really good. The same with lyrics |
|
Closed #13 since it was already fixed |
BobbyESP
left a comment
There was a problem hiding this comment.
For me all seems okay! Really thanks for your amazing job! If you have planned to do more work I'll wait, if not, gonna merge it to main branch
|
No problem! Happy I can help - used Jetispot off and on from before this fork so been wanting to contribute for a while. Thanks for reviewing PR during exams! Those are definitely more important 😄 I am happy for this to be merged now... not sure what to work on next just yet. Had a little look at Media3 migration and looks like a bigger task than I was anticipating (never migrated, only used Media3/ExoPlayer by itself) but more than happy to help out with it if you need a hand. |
|
Thanks mate and don't worry about Media3, it can wait. Google has a script that helps us to migrate the project automatically, so it may not be very hard. I still don't understand really well how Media3 works, a lot of things to touch at the same time and without good documentation... I think I will have to create a library for help with this |
|
Another time really thanks for the work you have put at the PR! |
Changes made:
FOREGROUND_SERVICE_MEDIA_PLAYBACKpermissionPromoCardHomeComponent.protoAlso I think #13 can be closed now too.