Skip to content
This repository was archived by the owner on Feb 16, 2025. It is now read-only.

Fix bugs, crashes, update 'your library' page & more#22

Merged
BobbyESP merged 17 commits intoBobbyESP:masterfrom
Outlet7493:master
Jan 27, 2024
Merged

Fix bugs, crashes, update 'your library' page & more#22
BobbyESP merged 17 commits intoBobbyESP:masterfrom
Outlet7493:master

Conversation

@Outlet7493
Copy link
Copy Markdown

@Outlet7493 Outlet7493 commented Jan 21, 2024

Changes made:

  • Update dependencies
  • Fix A14/SDK 34 crash missing FOREGROUND_SERVICE_MEDIA_PLAYBACK permission
  • HTML playlist description support - some playlists (e.g. Spotify's daylist feature) have HTML descriptions with links in them
  • Fix [Bug Report] Art cover and proper username doesn't show up my own playlists in the library section #21 (and as described in the issue):
    • Fixed username issue
    • Applied (temporary?) workaround to save playlist image if seen on home screen or returned from API when in playlist view
  • Implement [Feature Request] #9
    • Bottom sheet now has rounded corners at the top
    • Navbar only shows label of selected tab
  • Your library changes:
    • Fetch stored user profile image (to replace blank default one)
    • Match style to home screen
    • Implement search feature
    • Add support for "Your Episodes" entry instead of empty pinned playlist (screen itself still needs made)
    • Add support for pinned playlists
    • Remove duplicate and empty
  • Add support for PromoCardHomeComponent.proto
  • Fix crash when pressing play on album from home screen (haven't yet fixed the issue where playback doesn't start, but it no longer crashes)
  • Manually place album/playlist art on card (e.g. card on search screen) as the API returns just a color as the background image sometimes, so it now uses the main URI and moves it into place

Also I think #13 can be closed now too.

@BobbyESP
Copy link
Copy Markdown
Owner

Hi! First of all I want to thank you for the hard work in the project :). It's really nice to see people interested on helping, for real.

Leaving that at one side, I will be taking a look to the PR changes this afternoon (if I have time since I'm with exams) for reviewing all the changes.

If all it's good I will merge the PR in the main branch and, after that, the next step will be migrating to Media3 and rebuild the playback system since it's kinda broken 😂. It works, but not really good. The same with lyrics

@BobbyESP
Copy link
Copy Markdown
Owner

Closed #13 since it was already fixed

@BobbyESP BobbyESP self-requested a review January 22, 2024 14:48
Copy link
Copy Markdown
Owner

@BobbyESP BobbyESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me all seems okay! Really thanks for your amazing job! If you have planned to do more work I'll wait, if not, gonna merge it to main branch

@Outlet7493
Copy link
Copy Markdown
Author

No problem! Happy I can help - used Jetispot off and on from before this fork so been wanting to contribute for a while.

Thanks for reviewing PR during exams! Those are definitely more important 😄

I am happy for this to be merged now... not sure what to work on next just yet. Had a little look at Media3 migration and looks like a bigger task than I was anticipating (never migrated, only used Media3/ExoPlayer by itself) but more than happy to help out with it if you need a hand.

@BobbyESP
Copy link
Copy Markdown
Owner

Thanks mate and don't worry about Media3, it can wait. Google has a script that helps us to migrate the project automatically, so it may not be very hard. I still don't understand really well how Media3 works, a lot of things to touch at the same time and without good documentation... I think I will have to create a library for help with this

@BobbyESP
Copy link
Copy Markdown
Owner

Another time really thanks for the work you have put at the PR!

@BobbyESP BobbyESP merged commit d5eaab3 into BobbyESP:master Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] Art cover and proper username doesn't show up my own playlists in the library section

2 participants