bugfix: correct use_time_ratio min/max inversion in simple_impact_use#480
Merged
bugfix: correct use_time_ratio min/max inversion in simple_impact_use#480
Conversation
…ct_use In simple_impact_use, the use_time_ratio uncertainty bounds were swapped: max_impact was multiplied by use_time_ratio.min and min_impact by use_time_ratio.max. Since use_time_ratio is a positive multiplier (fraction of time the device is powered on), higher values produce higher impacts. The min/max should follow the same direction as all other terms. This bug affected ~20 device types routed through simple_impact_use: GPU, SSD, HDD, CASE, MOTHERBOARD, LAPTOP, DESKTOP, TABLET, SMARTPHONE, TELEVISION, BOX, MONITOR, VR headsets/controllers, and all IoT functional block types. It caused the reported uncertainty range (min/max) to be inverted for the use phase of these devices. The fix aligns simple_impact_use with all other impact functions (cpu_impact_use, server_impact_use, iot_impact_use, ram_impact_use, cloud_impact_use) which correctly pair .min with .min and .max with .max.
jonperron
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
simple_impact_use, the use_time_ratio uncertainty bounds were swapped:max_impactwas multiplied by use_time_ratio.min andmin_impactby use_time_ratio.max. Sinceuse_time_ratiois a positive multiplier (fraction of time the device is powered on), higher values produce higher impacts. The min/max should follow the same direction as all other terms.This bug affected ~20 device types routed through simple_impact_use: GPU, SSD, HDD, CASE, MOTHERBOARD, LAPTOP, DESKTOP, TABLET, SMARTPHONE, TELEVISION, BOX, MONITOR, VR headsets/controllers, and all IoT functional block types. It caused the reported uncertainty range (min/max) to be inverted for the use phase of these devices.
The fix aligns simple_impact_use with all other impact functions (cpu_impact_use, server_impact_use, iot_impact_use, ram_impact_use, cloud_impact_use) which correctly pair .min with .min and .max with .max.