Skip to content

fix(sdk): fixes for SDK build#433

Merged
Shillaker merged 1 commit intoBoavizta:mainfrom
Shillaker:fix/sdk-release-version
Jan 2, 2026
Merged

fix(sdk): fixes for SDK build#433
Shillaker merged 1 commit intoBoavizta:mainfrom
Shillaker:fix/sdk-release-version

Conversation

@Shillaker
Copy link
Copy Markdown
Collaborator

@Shillaker Shillaker commented Dec 31, 2025

Context

The SDK release build is failing with a syntax error in setup.py (e.g. in this run).

This is because we are setting it in a script using sed without quotation marks. We can instead pass the version directly to the generate command and it will quote the number properly.

Changes

  • Pass version number and Github properties directly to the OpenAPI generate command, rather than manually replacing with sed
  • Remove all unnecessary Python setup and installation in the Github Action (we don't need to install all the project dependencies or build the project, just poetry and twine)

@Shillaker Shillaker force-pushed the fix/sdk-release-version branch from 3fddad0 to f29f482 Compare January 2, 2026 09:19
@Shillaker Shillaker changed the title fix(sdk): quote release version in SDK build fix(sdk): fixes for SDK build Jan 2, 2026
@Shillaker Shillaker force-pushed the fix/sdk-release-version branch 6 times, most recently from 1e277b5 to da78251 Compare January 2, 2026 09:56
@Shillaker Shillaker force-pushed the fix/sdk-release-version branch from da78251 to 8d2c12d Compare January 2, 2026 10:01
@Shillaker Shillaker merged commit 2127aee into Boavizta:main Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants