fix(format): add formatting with pre-commit and CI#431
Merged
Shillaker merged 2 commits intoBoavizta:mainfrom Dec 31, 2025
Merged
fix(format): add formatting with pre-commit and CI#431Shillaker merged 2 commits intoBoavizta:mainfrom
Shillaker merged 2 commits intoBoavizta:mainfrom
Conversation
Collaborator
|
@Shillaker nitpick: you should have made several commits (at least two, with one containing only the automatic formatting), only one make the review very difficult. |
jonperron
approved these changes
Dec 30, 2025
.github/workflows/test.yml
Outdated
| with: | ||
| python-version: 3.12 | ||
|
|
||
| - name: Install pipenv |
Collaborator
There was a problem hiding this comment.
review: You are installing poetry, not pipenv next line
Collaborator
Author
There was a problem hiding this comment.
Ah good point, this is just copy-pasted from the other workflows. I fixed in all workflow files.
.github/workflows/test.yml
Outdated
| - dev | ||
|
|
||
| jobs: | ||
| format: |
Collaborator
There was a problem hiding this comment.
question: I am wondering if we could not create two separate workflows for format and lint, in addition to test.
Collaborator
Author
There was a problem hiding this comment.
Sure, I split it into three separate workflows.
Shillaker
force-pushed
the
fix/format-all-code
branch
from
2d45d49 to
f3bb9f0
Compare
Shillaker
force-pushed
the
fix/format-all-code
branch
from
f3bb9f0 to
09d4a0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #429
Changes
maketargets for formatting and checking formatting of codeNote: other than the changes to the CI and Makefile, all other changes are automatic formatting fixes applied by
ruff format.