fix(csv): fix get_archetype comparison#410
Merged
jnioche merged 1 commit intoBoavizta:mainfrom Jul 17, 2025
Merged
Conversation
Changelog * Use strip() method to prevent issues with space in data * Add tests to check all combinations (with/without space in both csv and payload)
jonperron
force-pushed
the
fix/space_in_csv
branch
from
5a60db2 to
8eb14e4
Compare
Collaborator
Author
|
This should answer your question about checking the value in the csv and testing @jnioche |
Collaborator
This would definitely make things more robust, thanks @jonperron |
jnioche
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Fix #406