Fix/issue 390 make test all instances detect error#395
Closed
ju3ouz4n wants to merge 4 commits intoBoavizta:mainfrom
Closed
Fix/issue 390 make test all instances detect error#395ju3ouz4n wants to merge 4 commits intoBoavizta:mainfrom
ju3ouz4n wants to merge 4 commits intoBoavizta:mainfrom
Conversation
…te_tests. Set use_url_params to True to make proper get request
Contributor
Author
|
|
ju3ouz4n
force-pushed
the
fix/issue-390-make-test-all-instances-detect-error
branch
2 times, most recently
from
044a529 to
14d9ae5
Compare
…o be able to switch DATA dir when executing tests (see make test) added two steps, one for test dir on for prod dir
… that need prod data to pass
ju3ouz4n
force-pushed
the
fix/issue-390-make-test-all-instances-detect-error
branch
from
14d9ae5 to
a979551
Compare
Collaborator
Contributor
Author
|
hi @Shillaker , i'm glad it can be useful, sorry i missed your comment. |
Collaborator
|
With all the recent changes on Let me know what you think, happy to mark you as a coauthor if you want. |
Collaborator
|
With the merge of #452 I think we can close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #390
Hi, hope everyone is ok!
Following discussions on this issue, i can suggest this PR that would allow test_all_instances to detect errors while allowing others tests to run with test data. As i understand switching to moke data for api integration tests might be a lot of work, this could improve stability while working in parralel on moke datas in the long run.
@da-ekchajzer @VincentVillet : Posting this PR gh-actions will certainly trigger tests, with 6 tests failing, urls mentionned in the issue.