fix: ark #8178
Merged
fix: ark #8178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| this._feePercentage = feesResponseJson?.ARK?.BTC?.fees?.percentage ?? 0; | ||
| if (!feesResponseJson?.ARK?.BTC?.fees?.percentage) { | ||
| console.log('warning: unexpected fees response from boltz:', JSON.stringify(feesResponseJson, null, 2)); | ||
| } |
There was a problem hiding this comment.
Bug: Warning triggers on valid zero fee percentage
The warning check uses a falsy test that incorrectly triggers when percentage is 0, even though zero is a valid fee percentage (as evidenced by the fallback value on line 171). The condition !feesResponseJson?.ARK?.BTC?.fees?.percentage evaluates to true when percentage is 0, causing false warnings. The check needs to test for undefined or null specifically rather than falsy values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Fixes Boltz ARK fee parsing and transaction amount calculation, adds Jest moduleNameMapper for expo/fetch, and updates integration test expectation.
class/wallets/lightning-ark-wallet.ts):feesResponseJson.ARK.BTCand log a warning on unexpected responses.getTransactions(), prefer decoded invoicenum_satoshisand adjust amount priority:expectedAmount || decodedValue || request.invoiceAmount || onchainAmount.jest.config.js: addmoduleNameMapperforexpo/fetch -> util/expo-fetch.js.10000intests/integration/lightning-ark-wallet.test.ts.Written by Cursor Bugbot for commit 956d937. This will update automatically on new commits. Configure here.