Skip to content

Conversation

@ojokne
Copy link
Member

@ojokne ojokne commented Nov 12, 2025

This PR continues replacing buffer with Uint8Array

@ojokne
Copy link
Member Author

ojokne commented Nov 12, 2025

@limpbrains should the use of buffer in the tests and blue_modules also be migrated to uint8Array

@ojokne
Copy link
Member Author

ojokne commented Nov 18, 2025

@limpbrains should the use of buffer in the tests and blue_modules also be migrated to uint8Array

@Overtorment could you advice here

@limpbrains
Copy link
Collaborator

@limpbrains should the use of buffer in the tests and blue_modules also be migrated to uint8Array

In the blue_modules - most definetly
In the tests - lowest priority

@Overtorment
Copy link
Member

in blue_modules some modules are actually dependencies that are copied from upstream, so they are not pulled from npm (usually because the developer is untrusted or to fix some issues). migrating it would be a wasted effort as it will be replaced in next update (pull from upstream)

@Overtorment
Copy link
Member

in tests - yeah, low priority, tests run in nodejs where Buffer is native

Copy link
Member

@Overtorment Overtorment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ojokne ojokne marked this pull request as ready for review November 27, 2025 14:13
@ojokne ojokne removed the WIP label Nov 27, 2025
@GladosBlueWallet
Copy link
Collaborator

@Overtorment Overtorment merged commit 01092cd into master Dec 5, 2025
13 of 14 checks passed
@Overtorment Overtorment deleted the remove-buffer branch December 5, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants