-
Notifications
You must be signed in to change notification settings - Fork 981
Add taproot wallet bip86 #8146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add taproot wallet bip86 #8146
Conversation
|
summon @junderw @ojokne @limpbrains @marcosrdz |
junderw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the script length, all the other stuff seems optional.
|
✅ Build 7.2.1 (1762513773) has been uploaded to TestFlight and will be available for testing soon. |
junderw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
✅ Build 7.2.1 (1762545792) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1762553991) has been uploaded to TestFlight and will be available for testing soon. |
ojokne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its not possible to import a Taproot wallet using seed words,
by default it imports HD SegWit (BIP84 Bech32 Native)
Steps to reproduce
- Create a new Taproot wallet and record the seed words
- Try to import the wallet and enter the same seed phrase
- Tap
Use custom derivation path
The Taproot derivation path (m/86'/0'/0') isn’t available among the options.
You can check screens/wallets/ImportCustomDerivationPath.tsx, lines 101–108, where the available wallet types are defined
const items: TItem[] = useMemo(() => {
if (wallets[path] === WRONG_PATH) return [];
return [
[HDLegacyP2PKHWallet.type, HDLegacyP2PKHWallet.typeReadable, used[path]?.[HDLegacyP2PKHWallet.type]],
[HDSegwitP2SHWallet.type, HDSegwitP2SHWallet.typeReadable, used[path]?.[HDSegwitP2SHWallet.type]],
[HDSegwitBech32Wallet.type, HDSegwitBech32Wallet.typeReadable, used[path]?.[HDSegwitBech32Wallet.type]],
];
}, [path, used, wallets]);|
Wake the fuck up samurai, we have PRs to merge [all PRs for @limpbrains] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/limpbrains |
|
Wake the fuck up samurai, we have PRs to merge [all PRs for @marcosrdz] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/marcosrdz |
|
✅ Build 7.2.1 (1762773534) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1762777227) has been uploaded to TestFlight and will be available for testing soon. |
|
@limpbrains now |
…proot-wallet-bip86
…dd-taproot-wallet-bip86
|
✅ Build 7.2.1 (1762798554) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1762798640) has been uploaded to TestFlight and will be available for testing soon. |
8da013f to
e11a785
Compare
|
@Overtorment Sorry, everything should be alright now. God bless the tests |
|
✅ Build 7.2.1 (1762802661) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1762802281) has been uploaded to TestFlight and will be available for testing soon. |

Note
Introduce HD Taproot (BIP86) wallet with p2tr derivation, PSBT/taproot signing, watch‑only/descriptors, import/export, and UI creation flow.
HDTaprootWallet(BIP86m/86'/0'/0',p2tr) with taproot address derivation, PSBT inputs, taproot signing, and Silent Payments p2tr support.p2tr(segwitType), cache master fingerprint, and p2tr coinselect weight.HDTaprootWalletin serialization/deserialization and exported types.p2tr; mapp2trtoHDTaprootWalletduring BIP39 scanning.tr(...)) and addWalletDescriptorhelper; generate descriptors for taproot watch‑only exports.HDTaprootWallet.tapBip32Derivation,tapInternalKey) and sign viasignTaprootInput.android:restartnpm script; bump iOS pods (lottie-react-native,RNLocalize).Written by Cursor Bugbot for commit 20f9896. This will update automatically on new commits. Configure here.