ADD: lightning wallet powered by ark #8142

Overtorment · 2025-10-24T18:30:43Z

Note

Adds a new Ark-powered Lightning wallet (arkade://) with swaps, UI integration, import flow, and supporting infra/config/tests; also removes the legacy LN additional info screen and refactors wallet selection/navigation.

Wallets/Core:
- New LightningArkWallet (class/wallets/lightning-ark-wallet.ts): Arkade + Boltz swap integration (generate/import arkade://, balance/tx fetch, invoice create/pay, boarding UTXOs, Ark address).
- Add deserialization/support across app (blue-app.ts, types.ts, index.ts, wallet-import.ts).
UI/UX:
- Treat LightningArkWallet like Lightning for gradients/images and Manage Funds (wallet-gradient.ts, TransactionsNavigationHeader.tsx, WalletsCarousel.tsx).
- Add hidden Add Wallet option and button for Ark wallet (screen/wallets/Add.tsx, components/WalletButton.tsx).
- Show Ark address in Wallet Details when applicable (screen/wallets/WalletDetails.tsx).
- Change expired tx icon (clock → timer) and minor tx item handling.
Navigation/Flows:
- Remove “Additional Invoice Information” LN screen/routes; streamline LN invoice/share screens.
- Update LNURL auth and create-invoice flows (close modal then navigate; use navigationRef).
- Refactor select-wallet to accept navigation object; update callers.
Infra/Config:
- Add @arkade-os/sdk and @arkade-os/boltz-swap deps; Metro aliases (expo/fetch shim, Ark adapter), Jest transform ignore updates; shim.js update; fetch timeout 20s.
Tests:
- New integration tests and fixtures for Ark wallet/import; adjust Lightning custodian tests.
Misc:
- SelfTest: verify Ark address generation.

^{Written by Cursor Bugbot for commit 1d4f557. This will update automatically on new commits. Configure here.}

socket-security · 2025-10-24T18:31:59Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/@arkade-os/sdk@0.3.5
	npm/@arkade-os/boltz-swap@0.2.8

View full report

class/wallets/lightning-ark-wallet.ts

github-actions · 2025-10-24T19:02:19Z

✅ Build 7.2.1 (1761331224) has been uploaded to TestFlight and will be available for testing soon.

github-actions · 2025-10-24T19:07:09Z

✅ Build 7.2.1 (1761331338) has been uploaded to TestFlight and will be available for testing soon.

class/wallets/lightning-ark-wallet.ts

github-actions · 2025-11-11T14:19:11Z

✅ Build 7.2.1 (1762869263) has been uploaded to TestFlight and will be available for testing soon.

class/wallets/lightning-ark-wallet.ts

github-actions · 2025-11-11T14:39:55Z

✅ Build 7.2.1 (1762870401) has been uploaded to TestFlight and will be available for testing soon.

class/wallets/lightning-ark-wallet.ts

github-actions · 2025-11-11T14:51:48Z

✅ Build 7.2.1 (1762871160) has been uploaded to TestFlight and will be available for testing soon.

github-actions · 2025-11-11T15:23:32Z

✅ Build 7.2.1 (1762872823) has been uploaded to TestFlight and will be available for testing soon.

class/blue-app.ts

class/wallets/lightning-ark-wallet.ts

github-actions · 2025-11-11T16:01:39Z

✅ Build 7.2.1 (1762875919) has been uploaded to TestFlight and will be available for testing soon.

cursor · 2025-11-11T17:05:11Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

cursor

Bug: Assertion Failure: Data Uninitialized

The test asserts that l1.info_raw is truthy, but the fetchInfo() method call was removed from the test. Since info_raw is initialized to false in the LightningCustodianWallet class and is never populated without calling fetchInfo(), this assertion will always fail.

tests/integration/lightning-custodian-wallet.test.js#L50-L51

BlueWallet/tests/integration/lightning-custodian-wallet.test.js

Lines 50 to 51 in 539b8b1

    
           assert.ok(l1.balance === 0); 
        
           assert.ok(l1.info_raw);

screen/wallets/Add.tsx

github-actions · 2025-11-13T15:55:26Z

✅ Build 7.2.1 (1763047984) has been uploaded to TestFlight and will be available for testing soon.

...78yvjau5kldfugg29k34y7j96q2w4t5d59wj0xp2nrkfxvszqruazjjtnuxw9v3larmelwtmsl4lr3tjnrrd9pem.bak

github-actions · 2025-11-13T17:26:22Z

✅ Build 7.2.1 (1763053281) has been uploaded to TestFlight and will be available for testing soon.

github-actions · 2025-11-13T20:03:15Z

✅ Build 7.2.1 (1763062800) has been uploaded to TestFlight and will be available for testing soon.

github-actions · 2025-11-13T21:14:42Z

✅ Build 7.2.1 (1763067234) has been uploaded to TestFlight and will be available for testing soon.

github-actions · 2025-11-13T22:07:31Z

✅ Build 7.2.1 (1763070343) has been uploaded to TestFlight and will be available for testing soon.

class/wallets/lightning-ark-wallet.ts

bordalix · 2025-11-14T07:00:49Z

class/wallets/lightning-ark-wallet.ts

+  async addInvoice(amt: number, memo: string) {
+    if (!this._wallet) await this.init();
+    assert(this._arkadeLightning, 'Ark Lightning not initialized');
+    assert(amt > 333, 'Only invoices > 333 sat allowed');


You should use limits.minimal from https://api.ark.boltz.exchange/v2/swap/submarine instead of hard coding 333.

Additionally, you should test if amt < limits.maximal (that you get from the same endpoint)

limpbrains

Show better error when trying to pay < 333

class/wallet-import.ts

class/wallets/lightning-ark-wallet.ts

github-actions · 2025-11-14T12:54:20Z

✅ Build 7.2.1 (1763123747) has been uploaded to TestFlight and will be available for testing soon.

github-actions · 2025-11-14T13:49:37Z

✅ Build 7.2.1 (1763126747) has been uploaded to TestFlight and will be available for testing soon.

github-actions · 2025-11-14T14:00:22Z

✅ Build 7.2.1 (1763126571) has been uploaded to TestFlight and will be available for testing soon.

github-actions · 2025-11-14T15:45:33Z

✅ Build 7.2.1 (1763133237) has been uploaded to TestFlight and will be available for testing soon.

limpbrains

I made a refill using an external address and sent the funds. The wallet showed a “Pending refill” status but provided no confirmation target or any additional information about what would happen next.
I tried tapping on it, but nothing happened.

When the transaction was confirmed, BlueWallet still didn’t update.
Only after restarting the app did it finalize the refill.

Overall, the procedure isn’t very clear.
It would be helpful to have a detailed status screen explaining what’s going on, along with a button to manually refresh or proceed.

Other than that, everything works fine.

Overtorment added the WIP label Oct 24, 2025

This comment was marked as outdated.

Sign in to view

Overtorment added the testflight Upload iOS and macOS builds to Testflight. label Oct 24, 2025

ADD: lightning ark wallet

a126b76

Overtorment force-pushed the add-ark-lightning branch from 1e64985 to a126b76 Compare October 24, 2025 18:34

cursor bot reviewed Oct 24, 2025

View reviewed changes

class/wallets/lightning-ark-wallet.ts Show resolved Hide resolved

Overtorment added 2 commits November 11, 2025 11:15

REF: resolved conflict

13eb764

wip

1bf7b56

cursor bot reviewed Nov 11, 2025

View reviewed changes

class/wallets/lightning-ark-wallet.ts Show resolved Hide resolved

wip

8cff17d

github-code-quality bot found potential problems Nov 11, 2025

View reviewed changes

class/wallets/lightning-ark-wallet.ts Fixed Show fixed Hide fixed

wip

44f3bfa

cursor bot reviewed Nov 11, 2025

View reviewed changes

class/wallets/lightning-ark-wallet.ts Show resolved Hide resolved

wip

4a01385

cursor bot reviewed Nov 11, 2025

View reviewed changes

class/wallets/lightning-ark-wallet.ts Show resolved Hide resolved

class/wallets/lightning-ark-wallet.ts Show resolved Hide resolved

wip

bfd1f42

cursor bot reviewed Nov 11, 2025

View reviewed changes

class/blue-app.ts Show resolved Hide resolved

class/wallets/lightning-ark-wallet.ts Show resolved Hide resolved

wip

539b8b1

cursor bot reviewed Nov 11, 2025

View reviewed changes

wip

5143bed

cursor bot reviewed Nov 11, 2025

View reviewed changes

screen/wallets/Add.tsx Show resolved Hide resolved

fix: select wallet crash

adca999

wip

34ff4e4

cursor bot reviewed Nov 13, 2025

View reviewed changes

...78yvjau5kldfugg29k34y7j96q2w4t5d59wj0xp2nrkfxvszqruazjjtnuxw9v3larmelwtmsl4lr3tjnrrd9pem.bak Outdated Show resolved Hide resolved

wip

da22e60

wip

c1ef3a2

Overtorment added 2 commits November 13, 2025 21:38

wip

91db95f

Merge remote-tracking branch 'origin/master' into add-ark-lightning

741fa4c

Overtorment requested review from limpbrains and marcosrdz November 13, 2025 21:40

bordalix suggested changes Nov 14, 2025

View reviewed changes

limpbrains requested changes Nov 14, 2025

View reviewed changes

class/wallet-import.ts Outdated Show resolved Hide resolved

class/wallets/lightning-ark-wallet.ts Show resolved Hide resolved

wip

aef6092

cursor bot reviewed Nov 14, 2025

View reviewed changes

class/wallets/lightning-ark-wallet.ts Outdated Show resolved Hide resolved

Overtorment added 2 commits November 14, 2025 13:09

wip

083d26c

wip

e4f5b19

wip

1d4f557

Overtorment requested review from bordalix and limpbrains November 14, 2025 22:29

limpbrains approved these changes Nov 15, 2025

View reviewed changes

Overtorment merged commit a0416b1 into master Nov 16, 2025
15 checks passed

Overtorment deleted the add-ark-lightning branch November 16, 2025 13:14

ADD: lightning wallet powered by ark #8142

ADD: lightning wallet powered by ark #8142

Uh oh!

Conversation

Overtorment commented Oct 24, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

socket-security bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 24, 2025

Uh oh!

github-actions bot commented Oct 24, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

cursor bot commented Nov 11, 2025

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Assertion Failure: Data Uninitialized

Uh oh!

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

Uh oh!

bordalix Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

limpbrains left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

limpbrains left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Overtorment commented Oct 24, 2025 •

edited by cursor bot

Loading

socket-security bot commented Oct 24, 2025 •

edited

Loading