FIX: taproot address unwrap from wif #8084
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Overtorment
force-pushed
the
fix-taproot-wif-address-unwrap
branch
from
43e8338 to
55bc394
Compare
| // Sign each input as a Taproot key-path spend | ||
| inputs.forEach((_, idx) => { | ||
| psbt.signTaprootInput(idx, keyPair); | ||
| psbt.signTaprootInput(idx, keyPair.tweak(bitcoin.crypto.taggedHash('TapTweak', xOnlyPub))); |
There was a problem hiding this comment.
@junderw is there a "proper" way to do this? feels hacky
Overtorment
force-pushed
the
fix-taproot-wif-address-unwrap
branch
from
55bc394 to
79f68bd
Compare
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @limpbrains] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/limpbrains |
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @junderw] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/junderw |
|
lgtm |
|
@Overtorment just a reminder that this will cause users who have already imported an untweaked taproot wif to no longer be able to see or spend their balance. Not sure there would actually be any of those users since I think the only way to end up in this state is to import the wif and already have funds in the untweaked key? But if you want to enable backwards compat you can enable this as a new wallet type like |
|
@lukechilds we discussed this internally and decided its ok. we didnt advertise this feature, theoretically there should be 0 users with stuck balance. worst case scenario we will deal with them one by one via support channel |
|
Yeah makes sense, just double checking. |
https://github.com/bitcoin/bips/blob/master/bip-0341.mediawiki#cite_note-23
now uwrapped address matches other wallets/services