ADD: Allow custom fees below 1 sat/vByte #7983
Conversation
|
oh ok. @ncoelho by default such transactions wont broadcast, they will show alert with error that rejectred by network rules or smth. do we need to show more explanation to the user about this? say, show extra warning if user chose feerate between |
limpbrains
left a comment
limpbrains
left a comment
There was a problem hiding this comment.
We need a warning and explanation
agree. @ncoelho your input on this? |
Thank you for your review, I will add the warning and explanation as requested |
I have added the warning and a simple explanation, Let me know if you would prefer a more specific message or any adjustments.
|
ojokne
force-pushed
the
allow-custom-fees-below-1-sat-per-vByte
branch
from
2762424 to
f8ff2b8
Compare
limpbrains
left a comment
limpbrains
left a comment
There was a problem hiding this comment.
We should probably adjust policy of BW node to allow such transactions
we can accept, but iirc it wont propagate and wont reach miners. such transactions currently can work only when you give it to miner and he mines it |
|
Looks good to me. |
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @ncoelho] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/ncoelho |
5 participants
Fixes #7964
This PR removes the restriction that prevented users from entering custom transaction fee rates below 1 sat/vB
Screenshot with custom fee set to 0 sat/vByte
Screenshot with custom fee set to 0.5 sat/vByte