FIX: isItMyAddress fails for uppercase Bech32 multisig addresses #7930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix detects if the address is Bech32, then normalizes it to lowercase before comparison Fixes BlueWallet#7888
ojokne
force-pushed
the
fix-bech32-validation
branch
from
8fe6974 to
671a64d
Compare
Member
|
feels like it was closed by mistake. @marcosrdz ..? |
Member
|
@limpbrains if you have no objections lets merge |
limpbrains
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix detects if the address is Bech32, then normalizes it to lowercase before comparison
Closes #7888