REF: SelectFee #7918
REF: SelectFee #7918
Conversation
Use builtin detents in RNav 7 isntead of using a dep package
|
built in what..? |
Sheetdetents. Basically builtin modals. Im gonna remove the dep once all modals use the builtin mechanism. Otherwise the PR will be far bigger |
|
e2e failed |
Fixed |
|
Not great not terrible |
can we do better on android ? |
|
If the issue with keyboard covering the form, I think we can do fee.webm |
| name="SelectFee" | ||
| component={SelectFeeScreen} | ||
| options={navigationStyle({ | ||
| sheetAllowedDetents: Platform.OS === 'ios' ? 'fitToContents' : [0.9], |
There was a problem hiding this comment.
E2e failed.
Gotta check why
Overtorment
left a comment
Overtorment
left a comment
There was a problem hiding this comment.
lgtm
@limpbrains whats the verdict? any changes necessary?
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @limpbrains] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/limpbrains |
|
we can adjust sheetAllowedDetents for android later.
|
|
Unbelievable. You, [subject name here], must be the pride of [subject hometown here]! |
Use builtin detents in RNav 7 isntead of using a dep package
https://reactnavigation.org/docs/native-stack-navigator/#sheetalloweddetents