Skip to content

REF: extract BlueLoading from BlueComponents.js #7912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Overtorment merged 4 commits into from
Jun 10, 2025
Merged

REF: extract BlueLoading from BlueComponents.js #7912

Overtorment merged 4 commits into from
Jun 10, 2025

Conversation

@danilobatson
Copy link
Contributor

@danilobatson danilobatson commented May 30, 2025

Closes #7911

Summary

This PR refactors the BlueLoading component by extracting it from BlueComponents.js into its own dedicated file (BlueLoading.tsx).

Changes

  • Removed BlueLoading from BlueComponents.js
  • Created a new BlueLoading.tsx file
  • In the spirit of keeping the commit small. Imports BlueLoading into BlueComponents.js where it is then exported for relevant files

Type of Change

  • Refactor (code change that does not affect external behavior)

Checklist

  • Code compiles without errors
  • All tests pass

ojokne
ojokne reviewed May 31, 2025
View reviewed changes
@danilobatson danilobatson requested a review from ojokne May 31, 2025 18:05
limpbrains
limpbrains requested changes May 31, 2025
View reviewed changes
@danilobatson danilobatson requested a review from limpbrains June 1, 2025 02:57
ojokne
ojokne approved these changes Jun 1, 2025
View reviewed changes
Copy link
Member

@ojokne ojokne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments appear to be resolved. I’ve tested the changes locally, and everything is working as intended. Looks good from my side.

@danilobatson
Copy link
Contributor Author

danilobatson commented Jun 2, 2025

@limpbrains can I get an assist on getting this merged? Have the two review approvals.

@marcosrdz marcosrdz requested a review from Overtorment June 3, 2025 01:05
@GladosBlueWallet
Copy link
Collaborator

GladosBlueWallet commented Jun 9, 2025

Wake the fuck up samurai, we have PRs to merge

image

[all PRs for @Overtorment] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/Overtorment

Overtorment
Overtorment approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@Overtorment Overtorment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Overtorment Overtorment merged commit ab1bbc1 into BlueWallet:master Jun 10, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@limpbrains limpbrains limpbrains approved these changes

@Overtorment Overtorment Overtorment approved these changes

@ojokne ojokne ojokne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move BlueLoading from BlueComponents.js to Its Own File

5 participants

@danilobatson @GladosBlueWallet @limpbrains @Overtorment @ojokne